Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc b/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc
index bd5a0847195a948f12ed77a918080725acba5d63..178cd2929a26b8892cfb11217c1c90926afc1444 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc
@@ -19,11 +19,13 @@ bool NGBidiParagraph::SetParagraph(const String& text,
DCHECK(!ubidi_);
ubidi_ = ubidi_open();
ICUError error;
- ubidi_setPara(ubidi_, text.characters16(), text.length(),
- block_style->unicodeBidi() == Plaintext
- ? UBIDI_DEFAULT_LTR
- : (block_style->direction() == RTL ? UBIDI_RTL : UBIDI_LTR),
- nullptr, &error);
+ ubidi_setPara(
+ ubidi_, text.characters16(), text.length(),
+ block_style->unicodeBidi() == Plaintext
+ ? UBIDI_DEFAULT_LTR
+ : (block_style->direction() == TextDirection::Rtl ? UBIDI_RTL
+ : UBIDI_LTR),
+ nullptr, &error);
if (U_FAILURE(error)) {
NOTREACHED();
ubidi_close(ubidi_);

Powered by Google App Engine
This is Rietveld 408576698