third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

index 6d01393db84bc2aaec7e7c0963a411d8d7199a74..0ee295408a9de83270e158fd5f60593ac4f59631 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

@@ -381,7 +381,8 @@ LayoutUnit InlineTextBox::placeEllipsisBox(bool flowIsLTR,

LayoutUnit widthOfVisibleText(getLineLayoutItem().width(

ltr == flowIsLTR ? m_start : m_start + offset,

ltr == flowIsLTR ? offset : m_len - offset, textPos(),

- flowIsLTR ? LTR : RTL, isFirstLineStyle()));

+ flowIsLTR ? TextDirection::Ltr : TextDirection::Rtl,

+ isFirstLineStyle()));

// The ellipsis needs to be placed just after the last visible character.

// Where "after" is defined by the flow directionality, not the inline