third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/TextRunConstructor.cpp ('k') | third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

index cc758ad52000d8d58c74399e5a95cf0cbf68a56e..0f681b53006462502eff7611554725399405bb9e 100644

--- a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

@@ -114,9 +114,12 @@ AbstractInlineTextBox::Direction AbstractInlineTextBox::getDirection() const {

if (!m_inlineTextBox || !m_lineLayoutItem)

return LeftToRight;

- if (m_lineLayoutItem.style()->isHorizontalWritingMode())

- return (m_inlineTextBox->direction() == RTL ? RightToLeft : LeftToRight);

- return (m_inlineTextBox->direction() == RTL ? BottomToTop : TopToBottom);

+ if (m_lineLayoutItem.style()->isHorizontalWritingMode()) {

+ return (m_inlineTextBox->direction() == TextDirection::Rtl ? RightToLeft

+ : LeftToRight);

+ }

+ return (m_inlineTextBox->direction() == TextDirection::Rtl ? BottomToTop

+ : TopToBottom);

}

void AbstractInlineTextBox::characterWidths(Vector<float>& widths) const {