Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index d9673fa25ee06b0138ebd53efbb1bc8e85a0e74b..3e9259b7c7be889d1f33349e627eeb998d7e2ece 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -3707,7 +3707,7 @@ void LayoutBox::computeInlineStaticDistance(
// FIXME: The static distance computation has not been patched for mixed
// writing modes yet.
- if (child->parent()->style()->direction() == LTR) {
+ if (child->parent()->style()->direction() == TextDirection::Ltr) {
LayoutUnit staticPosition = child->layer()->staticInlinePosition() -
containerBlock->borderLogicalLeft();
for (LayoutObject* curr = child->parent(); curr && curr != containerBlock;
@@ -4005,7 +4005,7 @@ void LayoutBox::computePositionedLogicalWidthUsing(
} else {
// Use the containing block's direction rather than the parent block's
// per CSS 2.1 reference test abspos-non-replaced-width-margin-000.
- if (containerDirection == LTR) {
+ if (containerDirection == TextDirection::Ltr) {
marginLogicalLeftValue = LayoutUnit();
marginLogicalRightValue = availableSpace; // will be negative
} else {
@@ -4032,7 +4032,7 @@ void LayoutBox::computePositionedLogicalWidthUsing(
// Use the containing block's direction rather than the parent block's
// per CSS 2.1 reference test abspos-non-replaced-width-margin-000.
- if (containerDirection == RTL)
+ if (containerDirection == TextDirection::Rtl)
logicalLeftValue = (availableSpace + logicalLeftValue) -
marginLogicalLeftValue - marginLogicalRightValue;
}

Powered by Google App Engine
This is Rietveld 408576698