Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
index 83b18fb7f37e7de0f774225c01335d8f662a72aa..4fabe1f0f43acd411006b7eb965457374f1d5785 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
@@ -546,7 +546,7 @@ static TextDirection determineDirectionality(const String& value,
bool& hasStrongDirectionality) {
TextRun run(value);
BidiResolver<VTTTextRunIterator, BidiCharacterRun> bidiResolver;
- bidiResolver.setStatus(BidiStatus(LTR, false));
+ bidiResolver.setStatus(BidiStatus(TextDirection::Ltr, false));
bidiResolver.setPositionIgnoringNestedIsolates(VTTTextRunIterator(&run, 0));
return bidiResolver.determineDirectionality(&hasStrongDirectionality);
}
@@ -558,7 +558,7 @@ static CSSValueID determineTextDirection(DocumentFragment* vttRoot) {
// concatenation of the values of each WebVTT Text Object in nodes, in a
// pre-order, depth-first traversal, excluding WebVTT Ruby Text Objects and
// their descendants.
- TextDirection textDirection = LTR;
+ TextDirection textDirection = TextDirection::Ltr;
Node* node = NodeTraversal::next(*vttRoot);
while (node) {
DCHECK(node->isDescendantOf(vttRoot));

Powered by Google App Engine
This is Rietveld 408576698