third_party/WebKit/Source/core/html/forms/RadioInputType.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

index 5e7ccf63daa4b3c58fdb31c9f96a3e6732f0aaa0..22790940dfe0207b69e0f09fb5889937ff751beb 100644

--- a/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

@@ -106,7 +106,7 @@ void RadioInputType::handleKeydownEvent(KeyboardEvent* event) {

Document& document = element().document();

if (isSpatialNavigationEnabled(document.frame()))

return;

- bool forward = computedTextDirection() == RTL

+ bool forward = computedTextDirection() == TextDirection::Rtl

? (key == "ArrowDown" || key == "ArrowLeft")

: (key == "ArrowDown" || key == "ArrowRight");