third_party/WebKit/Source/core/css/CSSProperty.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSProperty.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSProperty.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSProperty.cpp b/third_party/WebKit/Source/core/css/CSSProperty.cpp

index 6ab6ebda63371e7f1969998b63bc47a514dc3def..69452b0b07994110da6302901398e2fb0b16692c 100644

--- a/third_party/WebKit/Source/core/css/CSSProperty.cpp

+++ b/third_party/WebKit/Source/core/css/CSSProperty.cpp

@@ -53,7 +53,7 @@ static CSSPropertyID resolveToPhysicalProperty(

WritingMode writingMode,

LogicalBoxSide logicalSide,

const StylePropertyShorthand& shorthand) {

- if (direction == LTR) {

+ if (direction == TextDirection::Ltr) {

if (writingMode == TopToBottomWritingMode) {

// The common case. The logical and physical box sides match.

// Left = Start, Right = End, Before = Top, After = Bottom