Changed TextDirection to an enum class and renamed its members

third_party/WebKit/Source/core/layout/LayoutTextTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutText.h"
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/line/InlineTextBox.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 12 matching lines @@
     return toLayoutText(getLayoutObjectByElementId("target")->slowFirstChild());
   }
 };
 
 const char* kTacoText = "Los Compadres Taco Truck";
 
 }  // namespace
 
 TEST_F(LayoutTextTest, WidthZeroFromZeroLength) {
   setBasicBody(kTacoText);
-  ASSERT_EQ(0, getBasicText()->width(0u, 0u, LayoutUnit(), LTR, false));
+  ASSERT_EQ(0, getBasicText()->width(0u, 0u, LayoutUnit(), TextDirection::Ltr,
+                                     false));
 }
 
 TEST_F(LayoutTextTest, WidthMaxFromZeroLength) {
   setBasicBody(kTacoText);
   ASSERT_EQ(0, getBasicText()->width(std::numeric_limits<unsigned>::max(), 0u,
-                                     LayoutUnit(), LTR, false));
+                                     LayoutUnit(), TextDirection::Ltr, false));
 }
 
 TEST_F(LayoutTextTest, WidthZeroFromMaxLength) {
   setBasicBody(kTacoText);
   float width = getBasicText()->width(0u, std::numeric_limits<unsigned>::max(),
-                                      LayoutUnit(), LTR, false);
+                                      LayoutUnit(), TextDirection::Ltr, false);
   // Width may vary by platform and we just want to make sure it's something
   // roughly reasonable.
   ASSERT_GE(width, 100.f);
   ASSERT_LE(width, 160.f);
 }
 
 TEST_F(LayoutTextTest, WidthMaxFromMaxLength) {
   setBasicBody(kTacoText);
   ASSERT_EQ(0, getBasicText()->width(std::numeric_limits<unsigned>::max(),
                                      std::numeric_limits<unsigned>::max(),
-                                     LayoutUnit(), LTR, false));
+                                     LayoutUnit(), TextDirection::Ltr, false));
 }
 
 TEST_F(LayoutTextTest, WidthWithHugeLengthAvoidsOverflow) {
   // The test case from http://crbug.com/647820 uses a 288-length string, so for
   // posterity we follow that closely.
   setBodyInnerHTML(
       "<div "
       "id='target'>"
       "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       "xxxx"
       "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       "</div>");
   // Width may vary by platform and we just want to make sure it's something
   // roughly reasonable.
-  float width =
-      getBasicText()->width(23u, 4294967282u, LayoutUnit(2.59375), RTL, false);
+  float width = getBasicText()->width(23u, 4294967282u, LayoutUnit(2.59375),

[napper, 2016/12/07 05:27:13]

const float width = ...

[sashab, 2016/12/07 05:40:26]

Done

+                                      TextDirection::Rtl, false);
   ASSERT_GE(width, 100.f);
   ASSERT_LE(width, 300.f);
 }
 
 TEST_F(LayoutTextTest, WidthFromBeyondLength) {
   setBasicBody("x");
-  ASSERT_EQ(0u, getBasicText()->width(1u, 1u, LayoutUnit(), LTR, false));
+  ASSERT_EQ(0u, getBasicText()->width(1u, 1u, LayoutUnit(), TextDirection::Ltr,
+                                      false));
 }
 
 TEST_F(LayoutTextTest, WidthLengthBeyondLength) {
   setBasicBody("x");
   // Width may vary by platform and we just want to make sure it's something
   // roughly reasonable.
-  float width = getBasicText()->width(0u, 2u, LayoutUnit(), LTR, false);
+  float width =

[napper, 2016/12/07 05:27:13]

const float width = ...

[sashab, 2016/12/07 05:40:26]

Done

+      getBasicText()->width(0u, 2u, LayoutUnit(), TextDirection::Ltr, false);
   ASSERT_GE(width, 4.f);
   ASSERT_LE(width, 20.f);
 }
 
 }  // namespace blink