Changed TextDirection to an enum class and renamed its members

third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_inline_node.h"
 
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_fragment_builder.h"
 #include "core/layout/ng/ng_physical_text_fragment.h"
@@ skipping 67 matching lines @@
   EXPECT_EQ(start, item.StartOffset());                   \
   EXPECT_EQ(end, item.EndOffset());                       \
   EXPECT_EQ(direction, item.Direction())
 
 TEST_F(NGInlineNodeTest, SegmentASCII) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style_.get());
   node->Append("Hello");
   node->SegmentText();
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(1u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, LTR);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, TextDirection::Ltr);
 }
 
 TEST_F(NGInlineNodeTest, SegmentHebrew) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style_.get());
   node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA");
   node->SegmentText();
   ASSERT_EQ(1u, node->Items().size());
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(1u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, RTL);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 5u, TextDirection::Rtl);
 }
 
 TEST_F(NGInlineNodeTest, SegmentSplit1To2) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style_.get());
   node->Append(u"Hello \u05E2\u05D1\u05E8\u05D9\u05EA");
   node->SegmentText();
   ASSERT_EQ(2u, node->Items().size());
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(2u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[1], 6u, 11u, RTL);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[1], 6u, 11u, TextDirection::Rtl);
 }
 
 TEST_F(NGInlineNodeTest, SegmentSplit3To4) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style_.get());
   node->Append("Hel");
   node->Append(u"lo \u05E2");
   node->Append(u"\u05D1\u05E8\u05D9\u05EA");
   node->SegmentText();
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(4u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 3u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[1], 3u, 6u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[2], 6u, 7u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[3], 7u, 11u, RTL);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 3u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[1], 3u, 6u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[2], 6u, 7u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[3], 7u, 11u, TextDirection::Rtl);
 }
 
 TEST_F(NGInlineNodeTest, SegmentBidiOverride) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style_.get());
   node->Append("Hello ");
   node->Append(rightToLeftOverrideCharacter);
   node->Append("ABC");
   node->Append(popDirectionalFormattingCharacter);
   node->SegmentText();
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(4u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[2], 7u, 10u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[3], 10u, 11u, LTR);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[2], 7u, 10u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[3], 10u, 11u, TextDirection::Ltr);
 }
 
 static NGInlineNodeForTest* CreateBidiIsolateNode(const ComputedStyle* style) {
   NGInlineNodeForTest* node = new NGInlineNodeForTest(style);
   node->Append("Hello ", style);
   node->Append(rightToLeftIsolateCharacter);
   node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA ", style);
   node->Append(leftToRightIsolateCharacter);
   node->Append("A", style);
   node->Append(popDirectionalIsolateCharacter);
   node->Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA", style);
   node->Append(popDirectionalIsolateCharacter);
   node->Append(" World", style);
   node->SegmentText();
   return node;
 }
 
 TEST_F(NGInlineNodeTest, SegmentBidiIsolate) {
   NGInlineNodeForTest* node = CreateBidiIsolateNode(style_.get());
   Vector<NGLayoutInlineItem>& items = node->Items();
   ASSERT_EQ(9u, items.size());
-  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[2], 7u, 13u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[3], 13u, 14u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[4], 14u, 15u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[5], 15u, 16u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[6], 16u, 21u, RTL);
-  TEST_ITEM_OFFSET_DIR(items[7], 21u, 22u, LTR);
-  TEST_ITEM_OFFSET_DIR(items[8], 22u, 28u, LTR);
+  TEST_ITEM_OFFSET_DIR(items[0], 0u, 6u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[1], 6u, 7u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[2], 7u, 13u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[3], 13u, 14u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[4], 14u, 15u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[5], 15u, 16u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[6], 16u, 21u, TextDirection::Rtl);
+  TEST_ITEM_OFFSET_DIR(items[7], 21u, 22u, TextDirection::Ltr);
+  TEST_ITEM_OFFSET_DIR(items[8], 22u, 28u, TextDirection::Ltr);
 }
 
 #define TEST_TEXT_FRAGMENT(fragment, node, start_index, end_index, dir) \
   EXPECT_EQ(node, fragment->Node());                                    \
   EXPECT_EQ(start_index, fragment->StartIndex());                       \
   EXPECT_EQ(end_index, fragment->EndIndex());                           \
   EXPECT_EQ(dir, node->Items()[fragment->StartIndex()].Direction())
 
 TEST_F(NGInlineNodeTest, CreateLineBidiIsolate) {
   NGInlineNodeForTest* node = CreateBidiIsolateNode(style_.get());
   HeapVector<Member<NGPhysicalTextFragment>> fragments;
   CreateLine(node, 0, node->Items().size(), &fragments);
   ASSERT_EQ(5u, fragments.size());
-  TEST_TEXT_FRAGMENT(fragments[0], node, 0u, 1u, LTR);
-  TEST_TEXT_FRAGMENT(fragments[1], node, 6u, 7u, RTL);
-  TEST_TEXT_FRAGMENT(fragments[2], node, 4u, 5u, LTR);
-  TEST_TEXT_FRAGMENT(fragments[3], node, 2u, 3u, RTL);
-  TEST_TEXT_FRAGMENT(fragments[4], node, 8u, 9u, LTR);
+  TEST_TEXT_FRAGMENT(fragments[0], node, 0u, 1u, TextDirection::Ltr);
+  TEST_TEXT_FRAGMENT(fragments[1], node, 6u, 7u, TextDirection::Rtl);
+  TEST_TEXT_FRAGMENT(fragments[2], node, 4u, 5u, TextDirection::Ltr);
+  TEST_TEXT_FRAGMENT(fragments[3], node, 2u, 3u, TextDirection::Rtl);
+  TEST_TEXT_FRAGMENT(fragments[4], node, 8u, 9u, TextDirection::Ltr);
 }
 
 TEST_F(NGInlineNodeTest, CreateLineRangeBidiIsolate) {
   NGInlineNodeForTest* node = CreateBidiIsolateNode(style_.get());
   HeapVector<Member<NGPhysicalTextFragment>> fragments;
   CreateLine(node, 2, 7, &fragments);
   ASSERT_EQ(3u, fragments.size());
-  TEST_TEXT_FRAGMENT(fragments[0], node, 6u, 7u, RTL);
-  TEST_TEXT_FRAGMENT(fragments[1], node, 4u, 5u, LTR);
-  TEST_TEXT_FRAGMENT(fragments[2], node, 2u, 3u, RTL);
+  TEST_TEXT_FRAGMENT(fragments[0], node, 6u, 7u, TextDirection::Rtl);
+  TEST_TEXT_FRAGMENT(fragments[1], node, 4u, 5u, TextDirection::Ltr);
+  TEST_TEXT_FRAGMENT(fragments[2], node, 2u, 3u, TextDirection::Rtl);
 }
 
 }  // namespace blink