Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2356)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 void HTMLFormControlElement::updateVisibleValidationMessage() { 453 void HTMLFormControlElement::updateVisibleValidationMessage() {
454 Page* page = document().page(); 454 Page* page = document().page();
455 if (!page || !page->isPageVisible()) 455 if (!page || !page->isPageVisible())
456 return; 456 return;
457 String message; 457 String message;
458 if (layoutObject() && willValidate()) 458 if (layoutObject() && willValidate())
459 message = validationMessage().stripWhiteSpace(); 459 message = validationMessage().stripWhiteSpace();
460 460
461 m_hasValidationMessage = true; 461 m_hasValidationMessage = true;
462 ValidationMessageClient* client = &page->validationMessageClient(); 462 ValidationMessageClient* client = &page->validationMessageClient();
463 TextDirection messageDir = LTR; 463 TextDirection messageDir = TextDirection::Ltr;
464 TextDirection subMessageDir = LTR; 464 TextDirection subMessageDir = TextDirection::Ltr;
465 String subMessage = validationSubMessage().stripWhiteSpace(); 465 String subMessage = validationSubMessage().stripWhiteSpace();
466 if (message.isEmpty()) 466 if (message.isEmpty())
467 client->hideValidationMessage(*this); 467 client->hideValidationMessage(*this);
468 else 468 else
469 findCustomValidationMessageTextDirection(message, messageDir, subMessage, 469 findCustomValidationMessageTextDirection(message, messageDir, subMessage,
470 subMessageDir); 470 subMessageDir);
471 client->showValidationMessage(*this, message, messageDir, subMessage, 471 client->showValidationMessage(*this, message, messageDir, subMessage,
472 subMessageDir); 472 subMessageDir);
473 } 473 }
474 474
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 const Element& source) { 625 const Element& source) {
626 HTMLElement::copyNonAttributePropertiesFromElement(source); 626 HTMLElement::copyNonAttributePropertiesFromElement(source);
627 setNeedsValidityCheck(); 627 setNeedsValidityCheck();
628 } 628 }
629 629
630 void HTMLFormControlElement::associateWith(HTMLFormElement* form) { 630 void HTMLFormControlElement::associateWith(HTMLFormElement* form) {
631 associateByParser(form); 631 associateByParser(form);
632 }; 632 };
633 633
634 } // namespace blink 634 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698