Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2555873004: Remove ContextLifecycleObserver from ScriptPromisePropertyBase (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from ScriptPromisePropertyBase ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver. It can just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913 Cr-Commit-Position: refs/heads/master@{#436950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h View 4 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 12:11:26 UTC) #2
sof
lgtm this is a class that hasn't been without lifetime usage problems after execution contexts ...
4 years ago (2016-12-07 12:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555873004/1
4 years ago (2016-12-07 12:21:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:55:41 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913 Cr-Commit-Position: refs/heads/master@{#436950}
4 years ago (2016-12-07 14:57:14 UTC) #9
flackr
4 years ago (2016-12-07 22:05:05 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2557793004/ by flackr@chromium.org.

The reason for reverting is: This caused us to start failing the following tests
on WebKit Linux Trusty Leak (verified by local bisect):
virtual/service-worker-navigation-preload/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
virtual/mojo-loading/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/ready.html
imported/wpt/service-workers/service-worker/ready.https.html
http/tests/serviceworker/ready.html

First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty....

Powered by Google App Engine
This is Rietveld 408576698