Remove ContextLifecycleObserver from ScriptPromisePropertyBase

Remove ContextLifecycleObserver from ScriptPromisePropertyBase

ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
It can just hold a strong member to ExecutionContext.

BUG=610176
Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913
Cr-Commit-Position: refs/heads/master@{#436950}

[haraken, 2016-12-07 12:11:26]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-12-07 12:11:26]

PTAL

[sof, 2016-12-07 12:19:46]

lgtm

this is a class that hasn't been without lifetime usage problems after execution
contexts have been finalized/detached etc, but change looks fine wrt that.

[haraken, 2016-12-07 12:20:48]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-07 12:21:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:55:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481113248246410, "parent_rev":
"f1c6886d9f602380c15507b41506cc4b68ea3497", "commit_rev":
"c238eee33551c43f83192352ff82261437a6c9c1"}

[commit-bot: I haz the power, 2016-12-07 14:55:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 14:57:14]

Description was changed from

==========
Remove ContextLifecycleObserver from ScriptPromisePropertyBase

ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
It can just hold a strong member to ExecutionContext.

BUG=610176
==========

to

==========
Remove ContextLifecycleObserver from ScriptPromisePropertyBase

ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
It can just hold a strong member to ExecutionContext.

BUG=610176

Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913
Cr-Commit-Position: refs/heads/master@{#436950}
==========

[commit-bot: I haz the power, 2016-12-07 14:57:14]

Patchset 1 (id:??) landed as
https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913
Cr-Commit-Position: refs/heads/master@{#436950}

[flackr, 2016-12-07 22:05:05]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2557793004/ by flackr@chromium.org.

The reason for reverting is: This caused us to start failing the following tests
on WebKit Linux Trusty Leak (verified by local bisect):
virtual/service-worker-navigation-preload/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
virtual/mojo-loading/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/ready.html
imported/wpt/service-workers/service-worker/ready.https.html
http/tests/serviceworker/ready.html

First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty....