Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2555873002: ABANDONED CL: Revert of Suppress a use-after-free report in blink::RemoteFrame::detach(). (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL - replaced by https://codereview.chromium.org/2557903002/. ----------------- Revert of Suppress a use-after-free report in blink::RemoteFrame::detach(). (patchset #1 id:1 of https://codereview.chromium.org/819183006/ ) Reason for revert: Speculative revert - the original problem doesn't seem to repro anymore (per https://crbug.com/432070#c17) so let's try to remove the (hopefully) no longer needed test suppression. Original issue's description: > Suppress a use-after-free report in blink::RemoteFrame::detach(). > > BUG=432070 > TBR=japhet@chromium.org > NOTRY=true > > Committed: https://crrev.com/f54c1207ebe045798603f6484ad1f59aecad061c > Cr-Commit-Position: refs/heads/master@{#311154} TBR=japhet@chromium.org,jyasskin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=432070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Łukasz Anforowicz
Created Revert of Suppress a use-after-free report in blink::RemoteFrame::detach().
4 years ago (2016-12-06 20:11:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555873002/1
4 years ago (2016-12-06 20:12:29 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-06 20:16:45 UTC) #5
Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698