Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2555833003: Add functionality for Android. (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add functionality for Android. Tests can be run on Android simply by passing the --android flag with a device connected on adb. Removes usage of chrome_options. This object is parsed into capabilities in ChromeDriver anyways. This gives us more control over Chrome startup. BUG=669956 Committed: https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f Cr-Commit-Position: refs/heads/master@{#436793}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Prettier logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 1 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Robert Ogden
4 years ago (2016-12-06 22:20:50 UTC) #3
RyanSturm
lgtm % 1 comment https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdriver/common.py File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdriver/common.py#newcode129 tools/chrome_proxy/webdriver/common.py:129: if self._flags.android: Switch these cases ...
4 years ago (2016-12-06 22:32:15 UTC) #4
Robert Ogden
https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdriver/common.py File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdriver/common.py#newcode129 tools/chrome_proxy/webdriver/common.py:129: if self._flags.android: On 2016/12/06 22:32:15, Ryan Sturm wrote: > ...
4 years ago (2016-12-06 22:43:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555833003/20001
4 years ago (2016-12-06 23:06:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 00:49:02 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 00:51:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f
Cr-Commit-Position: refs/heads/master@{#436793}

Powered by Google App Engine
This is Rietveld 408576698