Add functionality for Android.

Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956
Committed: https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f
Cr-Commit-Position: refs/heads/master@{#436793}

[Robert Ogden, 2016-12-06 22:20:45]

Description was changed from

==========
Add functionality for Android.

BUG=669956
==========

to

==========
Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device
connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in
ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956
==========

[Robert Ogden, 2016-12-06 22:20:45]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[RyanSturm, 2016-12-06 22:32:15]

lgtm % 1 comment

https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:129: if self._flags.android:
Switch these cases around so you don't need to check .android twice:
if self._flags.android:
  ....
elif self._flags.chrome_exec:
  .....

[Robert Ogden, 2016-12-06 22:43:29]

https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2555833003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:129: if self._flags.android:
On 2016/12/06 22:32:15, Ryan Sturm wrote:
> Switch these cases around so you don't need to check .android twice:
> if self._flags.android:
>   ....
> elif self._flags.chrome_exec:
>   .....

Done.

[Robert Ogden, 2016-12-06 23:06:17]

The CQ bit was checked by robertogden@chromium.org

[Robert Ogden, 2016-12-06 23:06:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2555833003/#ps20001
(title: "Prettier logic")

[commit-bot: I haz the power, 2016-12-06 23:06:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:48:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481065577304870,
"parent_rev": "adf4d292b0206d2b10a4f3b65117cfa54d63996e", "commit_rev":
"e3eba20507c09523306ddd7deaf29b1087afa95f"}

[commit-bot: I haz the power, 2016-12-07 00:49:01]

Description was changed from

==========
Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device
connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in
ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956
==========

to

==========
Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device
connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in
ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956
==========

[commit-bot: I haz the power, 2016-12-07 00:49:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 00:51:12]

Description was changed from

==========
Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device
connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in
ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956
==========

to

==========
Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device
connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in
ChromeDriver anyways. This gives us more control over Chrome startup.

BUG=669956

Committed: https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f
Cr-Commit-Position: refs/heads/master@{#436793}
==========

[commit-bot: I haz the power, 2016-12-07 00:51:13]

Patchset 2 (id:??) landed as
https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f
Cr-Commit-Position: refs/heads/master@{#436793}