net/http/http_util.cc - Issue 2555813002: Don't consider '\0' as whitespace when parsing HTTP headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_util.cc

Issue 2555813002: Don't consider '\0' as whitespace when parsing HTTP headers. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_util.cc

diff --git a/net/http/http_util.cc b/net/http/http_util.cc

index 99b7192c838d500ce2bec2b783834f0bb94dfd22..61e33ca0ebaac4edc5b4aefe7f40c6305b640bea 100644

--- a/net/http/http_util.cc

+++ b/net/http/http_util.cc

@@ -426,7 +426,8 @@ bool HttpUtil::IsNonCoalescingHeader(std::string::const_iterator name_begin,

}

bool HttpUtil::IsLWS(char c) {

- return strchr(HTTP_LWS, c) != NULL;

+ base::StringPiece kLws(HTTP_LWS);

mmenke 2016/12/06 19:08:24 Needs a const. Also, LWS is one thing, but kLws s

eroman 2016/12/06 19:19:34 Done.

+ return kLws.find(c) != base::StringPiece::npos;

}

// static

« no previous file with comments | « no previous file | net/http/http_util_unittest.cc » ('j') | net/http/http_util_unittest.cc » ('J')