Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2555803003: Revise the generic methods doc. (Closed)

Created:
4 years ago by Bob Nystrom
Modified:
4 years ago
Reviewers:
Leaf, skybrian
CC:
dev-compiler+reviews_dartlang.org, skybrian, eernst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revise the generic methods doc. - Clarify up front that "methods" also applies to functions. - Note that it is an error to use a type parameter as a type literal. R=leafp@google.com, skybrian@google.com Committed: https://github.com/dart-lang/sdk/commit/c1da4705f5cb441f1986848409e8d0560a7d99ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M pkg/dev_compiler/doc/GENERIC_METHODS.md View 2 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
4 years ago (2016-12-06 19:48:31 UTC) #2
skybrian
LGTM. Thanks!
4 years ago (2016-12-06 20:10:58 UTC) #4
Leaf
lgtm
4 years ago (2016-12-06 21:13:37 UTC) #5
Bob Nystrom
4 years ago (2016-12-06 21:42:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1da4705f5cb441f1986848409e8d0560a7d99ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698