remoting/branding_Chromium - Issue 2555803002: Adding the iOS app and integration example with GlRenderer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/branding_Chromium

Issue 2555803002: Adding the iOS app and integration example with GlRenderer. (Closed)

Patch Set: Cleaning up gl_display_handler for chromium. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « remoting/branding_Chrome ('k') | remoting/client/ios/BUILD.gn » ('j') | remoting/client/ios/app/example_view_controller.h » ('J')

OLD	NEW
1 APK_PACKAGE_NAME=org.chromium.chromoting	1 APK_PACKAGE_NAME=org.chromium.chromoting

2 DAEMON_FILE_NAME=Chromoting Host Service	2 DAEMON_FILE_NAME=Chromoting Host Service

3 IT2ME_HOST_DESCRIPTION=Remote Assistance Host for Chromoting	3 IT2ME_HOST_DESCRIPTION=Remote Assistance Host for Chromoting

	4 IOS_BUNDLE_ID=org.chromium.Chromium

	5 IOS_DISPLAY_NAME=Chromoting for iOS

	6 IOS_EXEC_NAME=chromoting
	joedow 2017/01/25 23:16:28 Should these mimic the names in the Chrome brandin Should these mimic the names in the Chrome branding file? If so, exec name should be 'ChromotingiOS' and the product name should be 'Chromoting for iOS'. nicholss 2017/01/26 18:00:15 These values are not final. I am not sure What the Show quoted text On 2017/01/25 23:16:28, joedow wrote: > Should these mimic the names in the Chrome branding file? > > If so, exec name should be 'ChromotingiOS' and the product name should be > 'Chromoting for iOS'. > These values are not final. I am not sure What they will end up as. Product name here means the description that ends up the plist file, and I am not 100% sure but I think it is not suppose to have spaces. So all of these values will be updated as we get closer to shipping.
	7 IOS_PRODUCT_NAME=ChromotingForIos

4 MAC_BUNDLE_ID=org.chromium.Chromium	8 MAC_BUNDLE_ID=org.chromium.Chromium

5 MAC_CREATOR=Cr24	9 MAC_CREATOR=Cr24

6 MAC_HOST_BUNDLE_ID=org.chromium.chromoting.me2me-host	10 MAC_HOST_BUNDLE_ID=org.chromium.chromoting.me2me-host

7 MAC_HOST_BUNDLE_NAME=ChromotingHost.bundle	11 MAC_HOST_BUNDLE_NAME=ChromotingHost.bundle

8 MAC_HOST_PACKAGE_NAME=Chromoting Host	12 MAC_HOST_PACKAGE_NAME=Chromoting Host

9 MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=org.chromium.chromoting.native-messaging-hos t	13 MAC_NATIVE_MESSAGING_HOST_BUNDLE_ID=org.chromium.chromoting.native-messaging-hos t

10 MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.bundle	14 MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME=NativeMessagingHost.bundle

11 MAC_PREFPANE_BUNDLE_ID=org.chromium.remoting.preferences	15 MAC_PREFPANE_BUNDLE_ID=org.chromium.remoting.preferences

12 MAC_PREFPANE_BUNDLE_NAME=Chromoting.prefPane	16 MAC_PREFPANE_BUNDLE_NAME=Chromoting.prefPane

13 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=org.chromium.chromoting.remote-assistance-h ost	17 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_ID=org.chromium.chromoting.remote-assistance-h ost

14 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.bundle	18 MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME=RemoteAssistanceHost.bundle

15 MAC_UNINSTALLER_BUNDLE_ID=org.chromium.chromoting.me2me-host-uninstaller	19 MAC_UNINSTALLER_BUNDLE_ID=org.chromium.chromoting.me2me-host-uninstaller

16 MAC_UNINSTALLER_BUNDLE_PREFIX=org.chromium.pkg	20 MAC_UNINSTALLER_BUNDLE_PREFIX=org.chromium.pkg

17 MAC_UNINSTALLER_NAME=Chromoting Host Uninstaller	21 MAC_UNINSTALLER_NAME=Chromoting Host Uninstaller

18 ME2ME_HOST_DESCRIPTION=Chromoting Host	22 ME2ME_HOST_DESCRIPTION=Chromoting Host

OLD	NEW