Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3139)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 2555783002: [Mac] Ensure Omnibox text is always right-aligned in RTL (Closed)
Patch Set: Tweaks Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
index d90e5d8e64bfaf58f7b018d1053a345276fdbd0f..efe60017a5db23bb1eb838094cf092f08d6821c0 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
@@ -130,6 +130,10 @@ class OmniboxViewMac : public OmniboxView,
// Color used to draw suggest text.
static NSColor* SuggestTextColor();
+ // Apply our font and paragraph style to |attributedString|.
+ // Public for testing.
Elly Fong-Jones 2016/12/09 18:56:16 It's better to friend the test classes I think
lgrey 2016/12/09 19:43:15 Done.
+ void ApplyTextStyle(NSMutableAttributedString* attributedString);
+
AutocompleteTextField* field() const { return field_; }
private:
@@ -173,9 +177,6 @@ class OmniboxViewMac : public OmniboxView,
// though here we cannot really do the in-place operation they do.
void EmphasizeURLComponents() override;
- // Apply our font and paragraph style to |attributedString|.
- void ApplyTextStyle(NSMutableAttributedString* attributedString);
-
// Calculates text attributes according to |display_text| and applies them
// to the given |attributedString| object.
void ApplyTextAttributes(const base::string16& display_text,
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698