chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 2555783002: [Mac] Ensure Omnibox text is always right-aligned in RTL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 2555783002: [Mac] Ensure Omnibox text is always right-aligned in RTL (Closed)

Patch Set: User ScopedForceRTLMac for RTL test setup Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index d90e5d8e64bfaf58f7b018d1053a345276fdbd0f..18c18df08bfac0979d2a6ab525ac1e86d0e4c951 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -10,6 +10,7 @@

#include <memory>

+#include "base/gtest_prod_util.h"

#include "base/macros.h"

#include "base/strings/string16.h"

#include "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"

@@ -133,6 +134,8 @@ class OmniboxViewMac : public OmniboxView,

AutocompleteTextField* field() const { return field_; }

private:

+ FRIEND_TEST_ALL_PREFIXES(OmniboxViewMacTest, WritingDirectionLTR);

+ FRIEND_TEST_ALL_PREFIXES(OmniboxViewMacTest, WritingDirectionRTL);

// Called when the user hits backspace in |field_|. Checks whether

// keyword search is being terminated. Returns true if the

// backspace should be intercepted (not forwarded on to the standard