Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2555713002: Don't use FetchRequest in FrameFetchContext (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index e54aa91fc59dbd25841552ca59004ef33068e91a..2bfd8db5517547617176c441867a1a963976bafc 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -502,18 +502,19 @@ Resource* ResourceFetcher::requestResource(
FetchRequest& request,
const ResourceFactory& factory,
const SubstituteData& substituteData) {
+ ResourceRequest& resourceRequest = request.mutableResourceRequest();
+
unsigned long identifier = createUniqueIdentifier();
network_instrumentation::ScopedResourceLoadTracker scopedResourceLoadTracker(
- identifier, request.resourceRequest());
+ identifier, resourceRequest);
SCOPED_BLINK_UMA_HISTOGRAM_TIMER("Blink.Fetch.RequestResourceTime");
DCHECK(request.options().synchronousPolicy == RequestAsynchronously ||
factory.type() == Resource::Raw ||
factory.type() == Resource::XSLStyleSheet);
- context().populateRequestData(request.mutableResourceRequest());
- context().modifyRequestForCSP(request.mutableResourceRequest());
- context().addClientHintsIfNecessary(request);
- context().addCSPHeaderIfNecessary(factory.type(), request);
+ context().populateResourceRequest(
+ factory.type(), request.clientHintsPreferences(),
+ request.getResourceWidth(), resourceRequest);
// TODO(dproy): Remove this. http://crbug.com/659666
TRACE_EVENT1("blink", "ResourceFetcher::requestResource", "url",
@@ -522,15 +523,14 @@ Resource* ResourceFetcher::requestResource(
if (!request.url().isValid())
return nullptr;
- request.mutableResourceRequest().setPriority(computeLoadPriority(
+ resourceRequest.setPriority(computeLoadPriority(
factory.type(), request, ResourcePriority::NotVisible));
- initializeResourceRequest(request.mutableResourceRequest(), factory.type(),
- request.defer());
- network_instrumentation::resourcePrioritySet(
- identifier, request.resourceRequest().priority());
+ initializeResourceRequest(resourceRequest, factory.type(), request.defer());
+ network_instrumentation::resourcePrioritySet(identifier,
+ resourceRequest.priority());
ResourceRequestBlockedReason blockedReason = context().canRequest(
- factory.type(), request.resourceRequest(),
+ factory.type(), resourceRequest,
MemoryCache::removeFragmentIdentifierIfNeeded(request.url()),
request.options(), request.forPreload(), request.getOriginRestriction());
if (blockedReason != ResourceRequestBlockedReason::None) {
@@ -538,8 +538,8 @@ Resource* ResourceFetcher::requestResource(
return resourceForBlockedRequest(request, factory, blockedReason);
}
- context().willStartLoadingResource(
- identifier, request.mutableResourceRequest(), factory.type());
+ context().willStartLoadingResource(identifier, resourceRequest,
+ factory.type());
if (!request.url().isValid())
return nullptr;
@@ -563,7 +563,7 @@ Resource* ResourceFetcher::requestResource(
}
}
- bool isDataUrl = request.resourceRequest().url().protocolIsData();
+ bool isDataUrl = resourceRequest.url().protocolIsData();
bool isStaticData = isDataUrl || substituteData.isValid() || m_archive;
Resource* resource(nullptr);
if (isStaticData) {
@@ -591,7 +591,7 @@ Resource* ResourceFetcher::requestResource(
updateMemoryCacheStats(resource, policy, request, factory, isStaticData);
- request.mutableResourceRequest().setAllowStoredCredentials(
+ resourceRequest.setAllowStoredCredentials(
request.options().allowCredentials == AllowStoredCredentials);
switch (policy) {
@@ -602,7 +602,7 @@ Resource* ResourceFetcher::requestResource(
resource = createResourceForLoading(request, request.charset(), factory);
break;
case Revalidate:
- initializeRevalidation(request.mutableResourceRequest(), resource);
+ initializeRevalidation(resourceRequest, resource);
break;
case Use:
if (resource->isLinkPreload() && !request.isLinkPreload())
@@ -629,9 +629,8 @@ Resource* ResourceFetcher::requestResource(
// promotions. This can happen when a visible image's priority is increased
// and then another reference to the image is parsed (which would be at a
// lower priority).
- if (request.resourceRequest().priority() >
- resource->resourceRequest().priority())
- resource->didChangePriority(request.resourceRequest().priority(), 0);
+ if (resourceRequest.priority() > resource->resourceRequest().priority())
+ resource->didChangePriority(resourceRequest.priority(), 0);
}
// If only the fragment identifiers differ, it is the same resource.

Powered by Google App Engine
This is Rietveld 408576698