Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.h

Issue 2555713002: Don't use FetchRequest in FrameFetchContext (Closed)
Patch Set: a Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.h
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.h b/third_party/WebKit/Source/core/loader/FrameFetchContext.h
index 19aab5923072d027fe27461edaf22506afedfc35..62b908a562291770433c74250a398b23cc53abf6 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.h
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.h
@@ -33,6 +33,7 @@
#include "core/CoreExport.h"
#include "core/fetch/FetchContext.h"
+#include "core/fetch/FetchRequest.h"
#include "core/fetch/ResourceFetcher.h"
#include "core/frame/csp/ContentSecurityPolicy.h"
#include "core/loader/LinkLoader.h"
@@ -42,6 +43,7 @@
namespace blink {
+class ClientHintsPreferences;
class Document;
class DocumentLoader;
class LocalFrame;
@@ -145,10 +147,18 @@ class CORE_EXPORT FrameFetchContext final : public FetchContext {
void addConsoleMessage(const String&,
LogMessageType = LogErrorMessage) const override;
SecurityOrigin* getSecurityOrigin() const override;
- void modifyRequestForCSP(ResourceRequest&) override;
- void addClientHintsIfNecessary(FetchRequest&) override;
- void addCSPHeaderIfNecessary(Resource::Type, FetchRequest&) override;
- void populateRequestData(ResourceRequest&) override;
+
+ void populateResourceRequest(Resource::Type,
+ const ClientHintsPreferences&,
+ const FetchRequest::ResourceWidth&,
+ ResourceRequest&) override;
+ void setFirstPartyCookieAndRequestorOrigin(ResourceRequest&) override;
tyoshino (SeeGerritForStatus) 2017/01/10 09:55:56 aligned order of declaration populateResourceRequ
+
+ // Exposed for testing.
+ void modifyRequestForCSP(ResourceRequest&);
+ void addClientHintsIfNecessary(const ClientHintsPreferences&,
+ const FetchRequest::ResourceWidth&,
+ ResourceRequest&);
MHTMLArchive* archive() const override;
@@ -184,6 +194,8 @@ class CORE_EXPORT FrameFetchContext final : public FetchContext {
Resource*,
LinkLoader::CanLoadResources);
+ void addCSPHeaderIfNecessary(Resource::Type, ResourceRequest&);
+
// FIXME: Oilpan: Ideally this should just be a traced Member but that will
// currently leak because ComputedStyle and its data are not on the heap.
// See crbug.com/383860 for details.
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698