Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2555703003: [stubs] Add option to allow LO space allocation (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add option to allow LO space allocation Passing kAllowLargeObjectAllocation now allocates in LOS if necessary. Allow such allocations when growing fixed arrays in RegExp's @@match and @@split operations. BUG=chromium:670671 Committed: https://crrev.com/9c9c8d7bb5681c9fe2a0c2bbe21f97f8b33d9c46 Cr-Commit-Position: refs/heads/master@{#41526}

Patch Set 1 #

Patch Set 2 : Flag naming #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M src/builtins/builtins-regexp.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-670671.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
jgruber
4 years ago (2016-12-06 12:54:27 UTC) #7
Igor Sheludko
https://codereview.chromium.org/2555703003/diff/20001/src/runtime/runtime-internal.cc File src/runtime/runtime-internal.cc (right): https://codereview.chromium.org/2555703003/diff/20001/src/runtime/runtime-internal.cc#newcode257 src/runtime/runtime-internal.cc:257: RUNTIME_FUNCTION(Runtime_AllocateInLargeObjectSpace) { Probably it's better to use existing Runtime_AllocateInTargetSpace ...
4 years ago (2016-12-06 13:18:05 UTC) #10
jgruber
https://codereview.chromium.org/2555703003/diff/20001/src/runtime/runtime-internal.cc File src/runtime/runtime-internal.cc (right): https://codereview.chromium.org/2555703003/diff/20001/src/runtime/runtime-internal.cc#newcode257 src/runtime/runtime-internal.cc:257: RUNTIME_FUNCTION(Runtime_AllocateInLargeObjectSpace) { On 2016/12/06 13:18:05, Igor Sheludko wrote: > ...
4 years ago (2016-12-06 13:33:08 UTC) #13
Igor Sheludko
lgtm
4 years ago (2016-12-06 13:39:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555703003/40001
4 years ago (2016-12-06 14:07:00 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-06 14:08:46 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-06 14:09:04 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c9c8d7bb5681c9fe2a0c2bbe21f97f8b33d9c46
Cr-Commit-Position: refs/heads/master@{#41526}

Powered by Google App Engine
This is Rietveld 408576698