Sav: [turbofan][stubs] Further adapting machine graph verifier to code stubs.

src/compiler/machine-graph-verifier.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/machine-graph-verifier.h"
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/machine-operator.h"
@@ skipping 288 matching lines @@
               }
             } else {
               CheckValueInputForInt64Op(node, 0);
               CheckValueInputForInt64Op(node, 1);
             }
             break;
           case IrOpcode::kInt64LessThan:
           case IrOpcode::kInt64LessThanOrEqual:
           case IrOpcode::kUint64LessThan:
           case IrOpcode::kUint64LessThanOrEqual:
-            CheckValueInputForInt64Op(node, 0);
-            CheckValueInputForInt64Op(node, 1);
+            // Allows Smi operands in stubs.
+            CheckValueInputForInt64Op(node, 0, is_stub_);
+            CheckValueInputForInt64Op(node, 1, is_stub_);
+            if (is_stub_) {
+              CheckCompatibleValueInputRepresentations(node, 0, 1);
+            }
             break;
           case IrOpcode::kInt32x4ExtractLane:
             CheckValueInputRepresentationIs(node, 0,
                                             MachineRepresentation::kSimd128);
             break;
 #define LABEL(opcode) case IrOpcode::k##opcode:
           case IrOpcode::kChangeInt32ToTagged:
           case IrOpcode::kChangeUint32ToTagged:
           case IrOpcode::kChangeInt32ToFloat64:
           case IrOpcode::kChangeUint32ToFloat64:
@@ skipping 14 matching lines @@
             } else {
               CheckValueInputForInt32Op(node, 0);
               CheckValueInputForInt32Op(node, 1);
             }
             break;
 
           case IrOpcode::kInt32LessThan:
           case IrOpcode::kInt32LessThanOrEqual:
           case IrOpcode::kUint32LessThan:
           case IrOpcode::kUint32LessThanOrEqual:
-            MACHINE_BINOP_32_LIST(LABEL) {
-              CheckValueInputForInt32Op(node, 0);
-              CheckValueInputForInt32Op(node, 1);
+          case IrOpcode::kInt32Add:
+          case IrOpcode::kInt32Sub:
+            // Allows Smi operands in stubs.
+            CheckValueInputForInt32Op(node, 0, is_stub_);
+            CheckValueInputForInt32Op(node, 1, is_stub_);
+            if (is_stub_) {
+              CheckCompatibleValueInputRepresentations(node, 0, 1);
             }
             break;
+          case IrOpcode::kWord32And:
+          case IrOpcode::kWord32Or:
+          case IrOpcode::kWord32Xor:
+          case IrOpcode::kWord32Shl:
+          case IrOpcode::kWord32Shr:
+          case IrOpcode::kWord32Sar:
+          case IrOpcode::kWord32Ror:
+          case IrOpcode::kInt32Mul:
+          case IrOpcode::kInt32AddWithOverflow:
+          case IrOpcode::kInt32SubWithOverflow:
+          case IrOpcode::kInt32MulWithOverflow:
+          case IrOpcode::kInt32MulHigh:
+          case IrOpcode::kInt32Div:
+          case IrOpcode::kInt32Mod:
+          case IrOpcode::kUint32Div:
+          case IrOpcode::kUint32Mod:
+          case IrOpcode::kUint32MulHigh:
+            CheckValueInputForInt32Op(node, 0);
+            CheckValueInputForInt32Op(node, 1);
+            break;
             MACHINE_BINOP_64_LIST(LABEL) {
               CheckValueInputForInt64Op(node, 0);
               CheckValueInputForInt64Op(node, 1);
             }
             break;
           case IrOpcode::kFloat32Equal:
           case IrOpcode::kFloat32LessThan:
           case IrOpcode::kFloat32LessThanOrEqual:
             MACHINE_FLOAT32_BINOP_LIST(LABEL) {
               CheckValueInputForFloat32Op(node, 0);
@@ skipping 121 matching lines @@
     if (input_representation != representation) {
       std::stringstream str;
       str << "TypeError: node #" << node->id() << ":" << *node->op()
           << " uses node #" << input->id() << ":" << *input->op() << ":"
           << input_representation << " which doesn't have a " << representation
           << " representation.";
       FATAL(str.str().c_str());
     }
   }
 
+  MachineRepresentation Promote(MachineRepresentation rep) {
+    switch (rep) {
+      case MachineRepresentation::kBit:
+      case MachineRepresentation::kWord8:
+      case MachineRepresentation::kWord16:
+      case MachineRepresentation::kWord32:
+        return MachineRepresentation::kWord32;
+      case MachineRepresentation::kTagged:
+      case MachineRepresentation::kTaggedSigned:
+      case MachineRepresentation::kTaggedPointer:
+        return MachineRepresentation::kTagged;
+      default:
+        break;
+    }
+    return rep;
+  }
+
+  void CheckCompatibleValueInputRepresentations(Node const* node, int index1,
+                                                int index2) {
+    Node const* input1 = node->InputAt(index1);
+    MachineRepresentation input_representation1 =
+        inferrer_->GetRepresentation(input1);
+    Node const* input2 = node->InputAt(index2);
+    MachineRepresentation input_representation2 =
+        inferrer_->GetRepresentation(input2);
+    if (Promote(input_representation1) != Promote(input_representation2)) {
+      std::stringstream str;
+      str << "TypeError: node #" << node->id() << ":" << *node->op()
+          << " uses operands with incompatible representations: node #"
+          << input1->id() << ":" << *input1->op() << ":"
+          << input_representation1 << " and #" << input2->id() << ":"
+          << *input2->op() << ":" << input_representation2 << ".";
+      FATAL(str.str().c_str());
+    }
+  }
+
   void CheckValueInputIsTagged(Node const* node, int index) {
     Node const* input = node->InputAt(index);
     switch (inferrer_->GetRepresentation(input)) {
       case MachineRepresentation::kTagged:
       case MachineRepresentation::kTaggedPointer:
       case MachineRepresentation::kTaggedSigned:
         return;
       default:
         break;
     }
@@ skipping 30 matching lines @@
     if (inferrer_->GetRepresentation(input) !=
         MachineType::PointerRepresentation()) {
       std::ostringstream str;
       str << "TypeError: node #" << node->id() << ":" << *node->op()
           << " uses node #" << input->id() << ":" << *input->op()
           << " which doesn't have a tagged or pointer representation.";
       FATAL(str.str().c_str());
     }
   }
 
-  void CheckValueInputForInt32Op(Node const* node, int index) {
+  void CheckValueInputForInt32Op(Node const* node, int index,
+                                 bool allow_tagged = false) {
     Node const* input = node->InputAt(index);
     switch (inferrer_->GetRepresentation(input)) {
       case MachineRepresentation::kBit:
       case MachineRepresentation::kWord8:
       case MachineRepresentation::kWord16:
       case MachineRepresentation::kWord32:
         return;
+      case MachineRepresentation::kTagged:
+      case MachineRepresentation::kTaggedSigned:
+      case MachineRepresentation::kTaggedPointer:
+        if (Is32() && allow_tagged) {
+          return;
+        }
+        break;
       case MachineRepresentation::kNone: {
         std::ostringstream str;
         str << "TypeError: node #" << input->id() << ":" << *input->op()
             << " is untyped.";
         FATAL(str.str().c_str());
         break;
       }
       default:
         break;
     }
     std::ostringstream str;
     str << "TypeError: node #" << node->id() << ":" << *node->op()
         << " uses node #" << input->id() << ":" << *input->op()
         << " which doesn't have an int32-compatible representation.";
     FATAL(str.str().c_str());
   }
 
-  void CheckValueInputForInt64Op(Node const* node, int index) {
+  void CheckValueInputForInt64Op(Node const* node, int index,
+                                 bool allow_tagged = false) {
     Node const* input = node->InputAt(index);
     MachineRepresentation input_representation =
         inferrer_->GetRepresentation(input);
     switch (input_representation) {
       case MachineRepresentation::kWord64:
         return;
+      case MachineRepresentation::kTagged:
+      case MachineRepresentation::kTaggedSigned:
+      case MachineRepresentation::kTaggedPointer:
+        if (Is64() && allow_tagged) {
+          return;
+        }
+        break;
       case MachineRepresentation::kNone: {
         std::ostringstream str;
         str << "TypeError: node #" << input->id() << ":" << *input->op()
             << " is untyped.";
         FATAL(str.str().c_str());
         break;
       }
 
       default:
         break;
@@ skipping 130 matching lines @@
   MachineRepresentationInferrer representation_inferrer(schedule, graph,
                                                         linkage, temp_zone);
   MachineRepresentationChecker checker(schedule, &representation_inferrer,
                                        is_stub);
   checker.Run();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8