Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2555693003: Instant Apps: Split latency recordings into two. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Split latency recordings into two. Separately record the latency for Instant Apps API calls that result in an application being found and those that do not. BUG=670898 Committed: https://crrev.com/9595405d19bf5e40d885f753afe7ed47f6081b52 Cr-Commit-Position: refs/heads/master@{#437034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 2 chunks +27 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Maria
Sorry for the churn, we've decided to split recording of this metric into two -- ...
4 years ago (2016-12-07 00:17:33 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years ago (2016-12-07 16:44:30 UTC) #3
Ted C
On 2016/12/07 16:44:30, Alexei Svitkine wrote: > lgtm lgtm
4 years ago (2016-12-07 18:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555693003/1
4 years ago (2016-12-07 18:36:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:42:01 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-07 19:45:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9595405d19bf5e40d885f753afe7ed47f6081b52
Cr-Commit-Position: refs/heads/master@{#437034}

Powered by Google App Engine
This is Rietveld 408576698