Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2555673003: [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Originally landed as http://crrev.com/2513003002#ps1 Committed: https://crrev.com/302d816fa77d64bd662c13e64e5a71352b728cfc Cr-Commit-Position: refs/heads/master@{#436645}

Patch Set 1 #

Patch Set 2 : Changed variable to weak #

Patch Set 3 : remove unnecessary include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 1 chunk +1 line, -1 line 1 comment Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
stkhapugin
PTAL
4 years ago (2016-12-06 16:56:35 UTC) #2
sdefresne
lgtm
4 years ago (2016-12-06 16:59:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555673003/40001
4 years ago (2016-12-06 17:00:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-06 18:12:08 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/302d816fa77d64bd662c13e64e5a71352b728cfc Cr-Commit-Position: refs/heads/master@{#436645}
4 years ago (2016-12-06 18:15:21 UTC) #9
rohitrao (ping after 24h)
https://codereview.chromium.org/2555673003/diff/40001/ios/chrome/browser/ui/autofill/autofill_client_ios.h File ios/chrome/browser/ui/autofill/autofill_client_ios.h (right): https://codereview.chromium.org/2555673003/diff/40001/ios/chrome/browser/ui/autofill/autofill_client_ios.h#newcode99 ios/chrome/browser/ui/autofill/autofill_client_ios.h:99: __weak id<AutofillClientIOSBridge> bridge_; This header is included by both ...
4 years ago (2016-12-06 20:19:51 UTC) #11
rohitrao (ping after 24h)
4 years ago (2016-12-06 20:20:19 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2560453003/ by rohitrao@chromium.org.

The reason for reverting is: Non-ARC files that include autofill_client_ios.h
"cannot create __weak reference in file using manual reference counting"..

Powered by Google App Engine
This is Rietveld 408576698