Worker: Refine pending activity management on InProcessWorkerMessagingProxy

Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089
Committed: https://crrev.com/9d2e15b7c11d53baa8226bad662b26663838e035
Cr-Commit-Position: refs/heads/master@{#436549}

[nhiroki, 2016-12-06 06:25:38]

Description was changed from

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

BUG=655089
==========

to

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() because
    when it's greater than 0, m_workerGlobalScopeHasPendingActivities should be
    true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

BUG=655089
==========

[nhiroki, 2016-12-06 06:25:47]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 06:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-06 06:28:28]

Description was changed from

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() because
    when it's greater than 0, m_workerGlobalScopeHasPendingActivities should be
    true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

BUG=655089
==========

to

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

BUG=655089
==========

[nhiroki, 2016-12-06 06:31:09]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-12-06 06:31:13]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 06:31:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-06 06:32:11]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2016-12-06 06:32:12]

PTAL. This CL is inspired from https://codereview.chromium.org/2553973002/#msg6

[falken, 2016-12-06 06:51:54]

lgtm. Thanks this is a bit clearer. Add "This patch does not change behavior" in
the CL description?

[nhiroki, 2016-12-06 06:58:52]

Description was changed from

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

BUG=655089
==========

to

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089
==========

[nhiroki, 2016-12-06 06:59:07]

On 2016/12/06 06:51:54, falken wrote:
> lgtm. Thanks this is a bit clearer. Add "This patch does not change behavior"
in
> the CL description?

Thank you. Updated.

[nhiroki, 2016-12-06 07:07:16]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2016-12-06 07:07:19]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:07:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 07:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:24:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2016-12-06 08:07:16]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-12-06 08:07:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 09:15:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481011636587070,
"parent_rev": "ac9dc90695147c775c28c7021f9ede646d9e61a2", "commit_rev":
"3df7bd6f511be99d96bd20e40a878c4d3c803671"}

[commit-bot: I haz the power, 2016-12-06 09:16:21]

Description was changed from

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089
==========

to

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089
==========

[commit-bot: I haz the power, 2016-12-06 09:16:24]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-06 09:19:48]

Description was changed from

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089
==========

to

==========
Worker: Refine pending activity management on InProcessWorkerMessagingProxy

This CL...

(1) renames m_workerGlobalScopeMayHavePendingActivities to
    m_workerGlobalScopeHasPendingActivities. InProcessWorkerMessagingProxy
    cannot know the exact current state of pending activities on the worker
    context because it's in a separate thread, so the field name contained
    'may'. This would be confusing and pointless from caller's point of view.

(2) stops checking m_unconfirmedMessageCount in hasPendingActivity() in favor of
    m_workerGlobalScopeHasPendingActivities. When the count is greater than 0,
    m_workerGlobalScopeHasPendingActivities should be true.

(3) removes workerGlobalScopeMayHavePendingActivity() from
    InProcessWorkerMessagingProxyForTest because it's the same with
    hasPendingActivity() after (2).

Note that this CL does not change behavior.

BUG=655089

Committed: https://crrev.com/9d2e15b7c11d53baa8226bad662b26663838e035
Cr-Commit-Position: refs/heads/master@{#436549}
==========

[commit-bot: I haz the power, 2016-12-06 09:19:49]

Patchset 1 (id:??) landed as
https://crrev.com/9d2e15b7c11d53baa8226bad662b26663838e035
Cr-Commit-Position: refs/heads/master@{#436549}