third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp - Issue 2555653002: [WIP Prototype] ES6 https://html.spec.whatwg.org/#fetch-a-single-module-script implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

Issue 2555653002: [WIP Prototype] ES6 https://html.spec.whatwg.org/#fetch-a-single-module-script implementation (Closed)

Patch Set: ModuleTreeLinkerTest.fetchTreeInstantiationFailure Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

index fda3bcb4b64e543789bca503174aa168bc90f3d9..af24771a6095dfe5490d22acfc473531c269940f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

@@ -42,6 +42,7 @@ ScriptModule ScriptModule::Compile(v8::Isolate* isolate,

ScriptValue ScriptModule::Instantiate(ScriptState* script_state) {

v8::Isolate* isolate = script_state->GetIsolate();

v8::TryCatch try_catch(isolate);

+ try_catch.SetVerbose(true);

DCHECK(!IsNull());

v8::Local<v8::Context> context = script_state->GetContext();

@@ -55,7 +56,7 @@ ScriptValue ScriptModule::Instantiate(ScriptState* script_state) {

return ScriptValue();

}

-void ScriptModule::Evaluate(ScriptState* script_state) {

+void ScriptModule::Evaluate(ScriptState* script_state) const {

v8::Isolate* isolate = script_state->GetIsolate();

v8::TryCatch try_catch(isolate);

try_catch.SetVerbose(true);