Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2555653002: [WIP Prototype] ES6 https://html.spec.whatwg.org/#fetch-a-single-module-script implementation (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
index 379e5f18c13ca9c3082e3716f3dc3b0de7df1e82..2bd3354d7f53efb73009836cf9dced7db2a02ec2 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
@@ -547,7 +547,7 @@ void HTMLParserScriptRunner::requestParsingBlockingScript(Element* element) {
if (!parserBlockingScript())
return;
- DCHECK(parserBlockingScript()->resource());
+ // DCHECK(parserBlockingScript()->resource());
// We only care about a load callback if resource is not already in the cache.
// Callers will attempt to run the m_parserBlockingScript if possible before
@@ -583,7 +583,7 @@ void HTMLParserScriptRunner::requestDeferredScript(Element* element) {
}
}
- DCHECK(pendingScript->resource());
+ // DCHECK(pendingScript->resource());
// "Add the element to the end of the list of scripts that will execute
// when the document has finished parsing associated with the Document
@@ -599,7 +599,7 @@ PendingScript* HTMLParserScriptRunner::requestPendingScript(
// Here |resource| should be non-null. If it were nullptr,
// ScriptLoader::fetchScript() should have returned false and
// thus the control shouldn't have reached here.
- CHECK(resource);
+ // CHECK(resource);
return PendingScript::create(scriptElement, resource);
}

Powered by Google App Engine
This is Rietveld 408576698