Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h

Issue 2555653002: [WIP Prototype] ES6 https://html.spec.whatwg.org/#fetch-a-single-module-script implementation (Closed)
Patch Set: address haraken/yhirano comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
index 86e43650f2928423fe497d35822119ae5c9ed15e..f14398f0338bdd1459ed6edeb496fc0d6310741c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
@@ -48,6 +48,7 @@
namespace blink {
+class Modulator;
class V8DOMActivityLogger;
class V8PerContextData;
@@ -93,6 +94,9 @@ class CORE_EXPORT V8PerContextData final {
m_activityLogger = activityLogger;
}
+ Modulator* modulator() const { return m_modulator.get(); }
dominicc (has gone to gerrit) 2017/01/11 03:23:47 Hmm, interesting. Why not have ExecutionContext::m
kouhei (in TOK) 2017/01/17 05:26:13 Discussed offline. We need something in LocalWindo
+ void setModulator(Modulator*);
+
private:
V8PerContextData(v8::Local<v8::Context>);
@@ -122,6 +126,8 @@ class CORE_EXPORT V8PerContextData final {
// This is owned by a static hash map in V8DOMActivityLogger.
V8DOMActivityLogger* m_activityLogger;
+
+ Persistent<Modulator> m_modulator;
haraken 2017/01/11 02:31:28 ScopedPersistent?
kouhei (in TOK) 2017/01/17 05:26:13 Modulator is an Oilpan obj.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698