Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2555623003: WebFrameTest: use ReloadMainResource instead of Reload (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebFrameTest: use ReloadMainResource instead of Reload Now ReloadMainResource is used by default for reload operations. Let make all callers to use ReloadMainResource instead of Reload to be aligned with other use cases, and make Blink consistent. Once all callers are modified, I'd merge ReloadMainResource to Reload and make Reload behave as current ReloadMainResource does. BUG=670196 Committed: https://crrev.com/c8f59c2e1fc7ff7c45e006194547364deec4e2eb Cr-Commit-Position: refs/heads/master@{#436831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-06 13:24:21 UTC) #5
tkent
lgtm
4 years ago (2016-12-06 22:46:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555623003/1
4 years ago (2016-12-07 01:58:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 02:04:04 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 02:07:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8f59c2e1fc7ff7c45e006194547364deec4e2eb
Cr-Commit-Position: refs/heads/master@{#436831}

Powered by Google App Engine
This is Rietveld 408576698