Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3256)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc

Issue 2555623002: Last round of cleaning up MD layout constants. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
index 58cf38f81fbc7746d4234cd7f43134b57d8f1423..92cc1c299889b7f44359ce42dba8f6df6215147c 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
@@ -371,7 +371,7 @@ void BrowserNonClientFrameViewMus::TabStripDeleted(TabStrip* tab_strip) {
}
int BrowserNonClientFrameViewMus::GetTabStripLeftInset() const {
- const int pad = GetLayoutConstant(AVATAR_ICON_PADDING);
+ const int pad = kAvatarIconPadding;
Peter Kasting 2016/12/08 20:57:49 Nit: Use directly below?
Evan Stade 2016/12/13 01:31:17 Done.
const int avatar_right = profile_indicator_icon()
? (pad + GetIncognitoAvatarIcon().width())
: 0;
@@ -424,7 +424,7 @@ void BrowserNonClientFrameViewMus::LayoutIncognitoButton() {
DCHECK(browser_view()->IsTabStripVisible());
#endif
gfx::ImageSkia incognito_icon = GetIncognitoAvatarIcon();
- const int pad = GetLayoutConstant(AVATAR_ICON_PADDING);
+ const int pad = kAvatarIconPadding;
Peter Kasting 2016/12/08 20:57:49 Nit: Use directly below? Or make constexpr
Evan Stade 2016/12/13 01:31:17 Done.
int avatar_bottom =
GetTopInset(false) + browser_view()->GetTabStripHeight() - pad;
int avatar_y = avatar_bottom - incognito_icon.height();

Powered by Google App Engine
This is Rietveld 408576698