Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7114)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

Issue 2555623002: Last round of cleaning up MD layout constants. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
index b1377760f0f88e387abacc7a9cf2dc4898d5a165..b981eac4d56834fdc156f3a56d56046ae7e64df5 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
@@ -408,7 +408,7 @@ void BrowserNonClientFrameViewAsh::UpdateProfileIcons() {
// BrowserNonClientFrameViewAsh, private:
int BrowserNonClientFrameViewAsh::GetTabStripLeftInset() const {
- const int pad = GetLayoutConstant(AVATAR_ICON_PADDING);
+ const int pad = kAvatarIconPadding;
Peter Kasting 2016/12/08 20:57:49 Nit: Use directly below? If not, could make const
Evan Stade 2016/12/13 01:31:17 Done.
const int avatar_right =
profile_indicator_icon() ? (pad + GetIncognitoAvatarIcon().width()) : 0;
return avatar_right + pad;
@@ -448,7 +448,7 @@ void BrowserNonClientFrameViewAsh::LayoutProfileIndicatorIcon() {
#endif
const gfx::ImageSkia incognito_icon = GetIncognitoAvatarIcon();
- const int pad = GetLayoutConstant(AVATAR_ICON_PADDING);
+ const int pad = kAvatarIconPadding;
Peter Kasting 2016/12/08 20:57:49 Nit: Use directly below? Or make constexpr
Evan Stade 2016/12/13 01:31:17 Done.
const int avatar_bottom =
GetTopInset(false) + browser_view()->GetTabStripHeight() - pad;
int avatar_y = avatar_bottom - incognito_icon.height();

Powered by Google App Engine
This is Rietveld 408576698