Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 2555563003: Ignore 1xx informational headers. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 7b8a8597e6ecc957cecf293a3dfe715814eca408..459d015cf1b69ded7b5e3c3c4d8581435bb6da8b 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -4362,7 +4362,7 @@ TEST_F(SpdyNetworkTransactionTest, SpdyBasicAuth) {
"Basic realm=\"MyRealm\""
};
SpdySerializedFrame resp_authentication(spdy_util_.ConstructSpdyReplyError(
- "401 Authentication Required", kExtraAuthenticationHeaders,
+ "401", kExtraAuthenticationHeaders,
arraysize(kExtraAuthenticationHeaders) / 2, 1));
SpdySerializedFrame body_authentication(
spdy_util_.ConstructSpdyDataFrame(1, true));
@@ -6162,6 +6162,32 @@ TEST_F(SpdyNetworkTransactionTest, RstStreamNoErrorAfterResponse) {
EXPECT_EQ("hello!", out.response_data);
}
+TEST_F(SpdyNetworkTransactionTest, 100Continue) {
+ SpdySerializedFrame req(
+ spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
+ MockWrite writes[] = {CreateMockWrite(req, 0)};
+
+ SpdyHeaderBlock informational_headers;
+ informational_headers[spdy_util_.GetStatusKey()] = "100";
+ SpdySerializedFrame informational_response(
+ spdy_util_.ConstructSpdyReply(1, std::move(informational_headers)));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1));
+ SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true));
+ MockRead reads[] = {
+ CreateMockRead(informational_response, 1), CreateMockRead(resp, 2),
+ CreateMockRead(body, 3), MockRead(ASYNC, 0, 4) // EOF
+ };
+
+ SequencedSocketData data(reads, arraysize(reads), writes, arraysize(writes));
+ NormalSpdyTransactionHelper helper(CreateGetRequest(), DEFAULT_PRIORITY,
+ NetLogWithSource(), nullptr);
+ helper.RunToCompletion(&data);
+ TransactionHelperResult out = helper.output();
+ EXPECT_THAT(out.rv, IsOk());
+ EXPECT_EQ("HTTP/1.1 200", out.status_line);
+ EXPECT_EQ("hello!", out.response_data);
+}
+
class SpdyNetworkTransactionTLSUsageCheckTest
: public SpdyNetworkTransactionTest {
protected:

Powered by Google App Engine
This is Rietveld 408576698