third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h - Issue 2555543002: CSS Motion Path: Support offset-rotate in addition to offset-rotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h

Issue 2555543002: CSS Motion Path: Support offset-rotate in addition to offset-rotation (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css3/motion-path/offset-rotate.html ('K') | « third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt ('k') | third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp » ('j') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h

diff --git a/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h b/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h

index fd0f0dd37b5ef36735042e41b698123efc3f797a..45fafdaeebd69203da333990f4a59b1c90581ec2 100644

--- a/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h

+++ b/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h

@@ -13,7 +13,6 @@ class CSSOffsetRotationInterpolationType : public CSSInterpolationType {

public:

CSSOffsetRotationInterpolationType(PropertyHandle property)

: CSSInterpolationType(property) {

- DCHECK_EQ(cssProperty(), CSSPropertyOffsetRotation);

sashab 2016/12/06 04:16:34 Do you want DCHECK(property == offsetrotation || p

Eric Willigers 2016/12/06 05:30:04 Done.

}

InterpolationValue maybeConvertUnderlyingValue(