third_party/WebKit/Source/core/frame/UseCounter.cpp - Issue 2555543002: CSS Motion Path: Support offset-rotate in addition to offset-rotation

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2555543002: CSS Motion Path: Support offset-rotate in addition to offset-rotation (Closed)

Patch Set: comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google, Inc. All rights reserved.	2 * Copyright (C) 2012 Google, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 1032 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1043 case CSSPropertyAliasWebkitTextSizeAdjust:	1043 case CSSPropertyAliasWebkitTextSizeAdjust:

1044 return 537;	1044 return 537;

1045 case CSSPropertyOverflowAnchor:	1045 case CSSPropertyOverflowAnchor:

1046 return 538;	1046 return 538;

1047 case CSSPropertyUserSelect:	1047 case CSSPropertyUserSelect:

1048 return 539;	1048 return 539;

1049 case CSSPropertyOffsetDistance:	1049 case CSSPropertyOffsetDistance:

1050 return 540;	1050 return 540;

1051 case CSSPropertyOffsetPath:	1051 case CSSPropertyOffsetPath:

1052 return 541;	1052 return 541;

	1053 case CSSPropertyOffsetRotate:

1053 case CSSPropertyOffsetRotation:	1054 case CSSPropertyOffsetRotation:

	1055 // TODO(ericwilligers): Distinct use counter for CSSPropertyOffsetRotate.
	Rick Byers 2016/12/06 16:30:42 Might as well do this now, it's trivial right? Ch Might as well do this now, it's trivial right? Changing the meaning of UMA data over time makes analysis more confusing... Eric Willigers 2016/12/06 18:43:12 The intent is for this patch to be merged to M56 ( Show quoted text On 2016/12/06 16:30:42, Rick Byers wrote: > Might as well do this now, it's trivial right? Changing the meaning of UMA data > over time makes analysis more confusing... The intent is for this patch to be merged to M56 (design doc https://goo.gl/XFvGR8 ). We would need to assign use count 1692, and renumber CSSFlexibleBox ... CSSShadowPiercingDescendantCombinator = 1691, // The above items are available in M56 branch. CSSFlexibleBox = 1692, CSSGridLayout = 1693, Thus I attempted to instead keep this CL as simple as possible. The design doc proposes deprecation messages in M 57.
1054 return 542;	1056 return 542;

1055 case CSSPropertyOffset:	1057 case CSSPropertyOffset:

1056 return 543;	1058 return 543;

1057 case CSSPropertyOffsetAnchor:	1059 case CSSPropertyOffsetAnchor:

1058 return 544;	1060 return 544;

1059 case CSSPropertyOffsetPosition:	1061 case CSSPropertyOffsetPosition:

1060 return 545;	1062 return 545;

1061 case CSSPropertyTextDecorationSkip:	1063 case CSSPropertyTextDecorationSkip:

1062 return 546;	1064 return 546;

1063 case CSSPropertyCaretColor:	1065 case CSSPropertyCaretColor:

(...skipping 280 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1344 }	1346 }

1345 }	1347 }

1346	1348

1347 if (needsPagesMeasuredUpdate)	1349 if (needsPagesMeasuredUpdate)

1348 cssPropertiesHistogram.count(totalPagesMeasuredCSSSampleId());	1350 cssPropertiesHistogram.count(totalPagesMeasuredCSSSampleId());

1349	1351

1350 m_CSSBits.clearAll();	1352 m_CSSBits.clearAll();

1351 }	1353 }

1352	1354

1353 } // namespace blink	1355 } // namespace blink

OLD	NEW