Cleanup whitelist for screen capture access in getUserMedia()

Cleanup whitelist for screen capture access in getUserMedia()

1. Removed Google+ domains from the whitelist.
2. Chromecast extension ID is no longer hashed.
3. Deduped list of Chromecast extesions.

R=jiayl@chromium.org, mfoltz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266715

[mark a. foltz, 2014-04-25 17:28:13]

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:99: bool
IsOriginForCasting(const GURL& origin) {
I would say IsOriginOfWhitelistedExtension

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:101: // Whitelisted tab
casting extensions.
Can you please add a numbered comment:

1. Dev
2. Canary
3. Beta (Internal)
4. Google Cast Beta
5. Google Cast Stable

This will make the list consistent with
https://codereview.chromium.org/243663003/.

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:103: origin.spec() ==
"chrome-extension://pkedcjkdefgpdelpbcmbmeomcjbeemfm/" ||
This ID is unused and can be removed.

Can you please put the rest in the following order:

enhhojjnijigcajfphajepfemndkmdlo
hfaagokkkhdbgiakmmlclaapfelnkoah
fmfcbgogabcbclcofgocippekhfcmgfj
dliochdbjfkdbacpmhlcpmleaejidimm
boadgeojelhgndaghljhdicfkmllpafd

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:107: orogin.spec() ==
"chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/";
Typo in origin.

[Sergey Ulanov, 2014-04-25 21:02:26]

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:99: bool
IsOriginForCasting(const GURL& origin) {
On 2014/04/25 17:28:13, mark a. foltz wrote:
> I would say IsOriginOfWhitelistedExtension

I'd like to keep the current name (I'm not adding this function in this CL - it
was there before) to show that this is list for chromecast and nothing else.

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:101: // Whitelisted tab
casting extensions.
On 2014/04/25 17:28:13, mark a. foltz wrote:
> Can you please add a numbered comment:
> 
> 1. Dev
> 2. Canary
> 3. Beta (Internal)
> 4. Google Cast Beta
> 5. Google Cast Stable
> 
> This will make the list consistent with
> https://codereview.chromium.org/243663003/.

Done.

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:103: origin.spec() ==
"chrome-extension://pkedcjkdefgpdelpbcmbmeomcjbeemfm/" ||
On 2014/04/25 17:28:13, mark a. foltz wrote:
> This ID is unused and can be removed.
> 
> Can you please put the rest in the following order:
> 
> enhhojjnijigcajfphajepfemndkmdlo
This one wasn't in the list before - do you really need it?

> hfaagokkkhdbgiakmmlclaapfelnkoah
> fmfcbgogabcbclcofgocippekhfcmgfj
> dliochdbjfkdbacpmhlcpmleaejidimm
> boadgeojelhgndaghljhdicfkmllpafd

Done.

https://codereview.chromium.org/255553007/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:107: orogin.spec() ==
"chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/";
On 2014/04/25 17:28:13, mark a. foltz wrote:
> Typo in origin.

Done.

[mark a. foltz, 2014-04-25 21:44:38]

lgtm

https://codereview.chromium.org/255553007/diff/40001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/255553007/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:98: #define
OFFICIAL_BUILD
Did you intend to add this?

[Sergey Ulanov, 2014-04-25 21:57:58]

https://codereview.chromium.org/255553007/diff/40001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/255553007/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:98: #define
OFFICIAL_BUILD
On 2014/04/25 21:44:38, mark a. foltz wrote:
> Did you intend to add this?

no - just wanted to make sure it compiles as official build, and forgot to
remove it. Thanks for catching it.

[jiayl, 2014-04-28 16:50:14]

lgtm

[Sergey Ulanov, 2014-04-28 17:37:10]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:37:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/255553007/60001

[commit-bot: I haz the power, 2014-04-28 21:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:43:27]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Sergey Ulanov, 2014-04-29 00:18:43]

Committed patchset #4 manually as r266715 (presubmit successful).