Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 255553004: Split [StrictTypeChecking] into [TypeChecking=Interface|Nullable|String] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove redundant flag Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/idls/TestInterface.idl ('k') | Source/bindings/tests/idls/TestSpecialOperations.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/idls/TestObject.idl
diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl
index 7ed496e006ea649631fcd5f2e4a7db132db63fb2..859c573348216a563ee753b9497793beb6cffd40 100644
--- a/Source/bindings/tests/idls/TestObject.idl
+++ b/Source/bindings/tests/idls/TestObject.idl
@@ -233,9 +233,10 @@ interface TestObject {
[Conditional=CONDITION, RuntimeEnabled=FeatureName] attribute long conditionalRuntimeEnabledLongAttribute;
[SetterCallWith=ActiveWindow&FirstWindow] attribute DOMString setterCallWithActiveWindowAndFirstWindowStringAttribute;
[SetterCallWith=ExecutionContext] attribute DOMString setterCallWithExecutionContextStringAttribute;
- [StrictTypeChecking] attribute float strictTypeCheckingFloatAttribute; // nop for non-interface types
- [StrictTypeChecking] attribute TestInterface strictTypeCheckingTestInterfaceAttribute;
- [StrictTypeChecking] attribute TestInterface? strictTypeCheckingNullableTestInterfaceAttribute;
+ [TypeChecking=Interface|Nullable|String] attribute float strictTypeCheckingInterfaceNullableStringFloatAttribute; // nop for non-interface types
+ [TypeChecking=Interface] attribute TestInterface strictTypeCheckingInterfaceTestInterfaceAttribute;
+ [TypeChecking=Nullable] attribute TestInterface? strictTypeCheckingNullableTestInterfaceOrNullAttribute;
+ [TypeChecking=Interface|Nullable] attribute TestInterface? strictTypeCheckingInterfaceNullableTestInterfaceOrNullAttribute;
[TreatNullAs=NullString] attribute DOMString treatNullAsNullStringStringAttribute;
[TreatReturnedNullStringAs=Null] attribute DOMString treatReturnedNullStringAsNullStringAttribute;
[TreatReturnedNullStringAs=Undefined] attribute DOMString treatReturnedNullStringAsUndefinedStringAttribute;
@@ -392,9 +393,9 @@ interface TestObject {
void overloadedMethodE(long longArg);
void overloadedMethodE(long[] longArrayArg);
void overloadedMethodF(long longArg);
- void overloadedMethodF(TestInterfaceEmpty? testInterfaceEmptyNullableArg);
+ void overloadedMethodF(TestInterfaceEmpty? testInterfaceEmptyOrNullArg);
void overloadedMethodG();
- void overloadedMethodG([StrictTypeChecking] DOMString strictTypeCheckingStringArg);
+ void overloadedMethodG([TypeChecking=String] DOMString strictTypeCheckingStringStringArg);
void overloadedMethodH();
void overloadedMethodH(TestCallbackInterface testCallbackInterfaceArg);
// FIXME: Should be in order double, Dictionary, but Blink implementation of
@@ -402,7 +403,7 @@ interface TestObject {
void overloadedMethodI(Dictionary dictionaryArg); // Non-wrapper type
void overloadedMethodI(double doubleArg);
void overloadedMethodJ(long longArg);
- void overloadedMethodJ([Default=Null] TestInterfaceEmpty? testInterfaceEmptyNullableArg);
+ void overloadedMethodJ([Default=Null] TestInterfaceEmpty? testInterfaceEmptyOrNullArg);
[PerWorldBindings] void overloadedPerWorldBindingsMethod();
@@ -469,8 +470,9 @@ interface TestObject {
[NotEnumerable, ReadOnly] void notEnumerableReadOnlyVoidMethod();
[RuntimeEnabled=FeatureName] void runtimeEnabledVoidMethod();
[PerWorldBindings, RuntimeEnabled=FeatureName] void perWorldBindingsRuntimeEnabledVoidMethod();
- [StrictTypeChecking] void strictTypeCheckingVoidMethodTestInterfaceEmptyArg(TestInterfaceEmpty testInterfaceEmptyArg);
- [StrictTypeChecking] void strictTypeCheckingVoidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty? testInterfaceEmptyArg);
+ [TypeChecking=Interface] void strictTypeCheckingInterfaceVoidMethodTestInterfaceEmptyArg(TestInterfaceEmpty testInterfaceEmptyArg);
+ [TypeChecking=Nullable] void strictTypeCheckingNullableVoidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty? testInterfaceEmptyOrNullArg);
+ [TypeChecking=Interface|Nullable] void strictTypeCheckingInterfaceNullableVoidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty? testInterfaceEmptyOrNullArg);
[TreatReturnedNullStringAs=Null] DOMString treatReturnedNullStringAsNullStringMethod();
[TreatReturnedNullStringAs=Undefined] DOMString treatReturnedNullStringAsUndefinedStringMethod();
[Unforgeable] void unforgeableVoidMethod();
« no previous file with comments | « Source/bindings/tests/idls/TestInterface.idl ('k') | Source/bindings/tests/idls/TestSpecialOperations.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698