Source/bindings/templates/interface.cpp - Issue 255553004: Split [StrictTypeChecking] into [TypeChecking=Interface|Nullable|String]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.cpp

Issue 255553004: Split [StrictTypeChecking] into [TypeChecking=Interface|Nullable|String] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove redundant flag Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/interface.cpp

diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp

index c7d7266ae72ae978b7caf3e31e3c885abe290588..b4f9887c0703eaaf71a607e0a5db974350e8f655 100644

--- a/Source/bindings/templates/interface.cpp

+++ b/Source/bindings/templates/interface.cpp

@@ -184,7 +184,7 @@ static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> v8Value,

{% if setter.has_exception_state %}

ExceptionState exceptionState(ExceptionState::IndexedSetterContext, "{{interface_name}}", info.Holder(), info.GetIsolate());

{% endif %}

- {% if setter.has_strict_type_checking %}

+ {% if setter.has_type_checking_interface %}

{# Type checking for interface types (if interface not implemented, throw

TypeError), per http://www.w3.org/TR/WebIDL/#es-interface #}

if (!isUndefinedOrNull(v8Value) && !V8{{setter.idl_type}}::hasInstance(v8Value, info.GetIsolate())) {

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »