cc/trees/layer_tree_host_common.h - Issue 255553003: Revert of [#7] Pass gfx structs by const ref (gfx::Size)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_common.h

Issue 255553003: Revert of [#7] Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_common.h

diff --git a/cc/trees/layer_tree_host_common.h b/cc/trees/layer_tree_host_common.h

index 57ea16d9edb8f3e736f4fa6a1ee49d815e868cab..cd30b938b8d7f197c48d593dd6a98631557585c3 100644

--- a/cc/trees/layer_tree_host_common.h

+++ b/cc/trees/layer_tree_host_common.h

@@ -32,7 +32,7 @@

struct CalcDrawPropsInputs {

public:

CalcDrawPropsInputs(LayerType* root_layer,

- const gfx::Size& device_viewport_size,

+ gfx::Size device_viewport_size,

const gfx::Transform& device_transform,

float device_scale_factor,

float page_scale_factor,

@@ -72,12 +72,12 @@

: public CalcDrawPropsInputs<LayerType, RenderSurfaceLayerListType> {

CalcDrawPropsInputsForTesting(

LayerType* root_layer,

- const gfx::Size& device_viewport_size,

+ gfx::Size device_viewport_size,

const gfx::Transform& device_transform,

RenderSurfaceLayerListType* render_surface_layer_list);

CalcDrawPropsInputsForTesting(

LayerType* root_layer,

- const gfx::Size& device_viewport_size,

+ gfx::Size device_viewport_size,

RenderSurfaceLayerListType* render_surface_layer_list);

private:

@@ -126,7 +126,7 @@

// given transform.

template <typename LayerType>

static void ApplySublayerTransformAboutAnchor(const LayerType& layer,

- const gfx::Size& bounds,

+ gfx::Size bounds,

gfx::Transform* transform) {

if (!layer.sublayer_transform().IsIdentity()) {

transform->Translate(layer.anchor_point().x() * bounds.width(),

@@ -227,7 +227,7 @@

RenderSurfaceLayerListType>::

CalcDrawPropsInputsForTesting(

LayerType* root_layer,

- const gfx::Size& device_viewport_size,

+ gfx::Size device_viewport_size,

const gfx::Transform& device_transform,

RenderSurfaceLayerListType* render_surface_layer_list)

: CalcDrawPropsInputs<LayerType, RenderSurfaceLayerListType>(

@@ -251,7 +251,7 @@

RenderSurfaceLayerListType>::

CalcDrawPropsInputsForTesting(

LayerType* root_layer,

- const gfx::Size& device_viewport_size,

+ gfx::Size device_viewport_size,

RenderSurfaceLayerListType* render_surface_layer_list)

: CalcDrawPropsInputs<LayerType, RenderSurfaceLayerListType>(

root_layer,

« no previous file with comments | « cc/trees/layer_tree_host.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »