Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Issue 2555513003: [Android] Sort custom search engines based on last visited time and display only top 3 most recentl… (Closed)
Patch Set: Update based on Ted's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
index 5af07f101e96d8d5475ce20eb19b638fa400d583..8ff89e9bf027cebe323cabd50bc1bd50e0bf69fa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
@@ -9,6 +9,7 @@ import android.text.TextUtils;
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
import java.lang.annotation.Retention;
@@ -373,6 +374,16 @@ public class TemplateUrlService {
return nativeGetSearchEngineUrlFromTemplateUrl(mNativeTemplateUrlServiceAndroid, keyword);
}
+ @VisibleForTesting
+ public String addSearchEngineForTesting(String keyword, int offset) {
Ted C 2016/12/15 23:40:37 update the java var names too
+ return nativeAddSearchEngineForTesting(mNativeTemplateUrlServiceAndroid, keyword, offset);
+ }
+
+ @VisibleForTesting
+ public String updateLastVisitedForTesting(String keyword) {
+ return nativeUpdateLastVisitedForTesting(mNativeTemplateUrlServiceAndroid, keyword);
+ }
+
private native long nativeInit();
private native void nativeLoad(long nativeTemplateUrlServiceAndroid);
private native boolean nativeIsLoaded(long nativeTemplateUrlServiceAndroid);
@@ -394,4 +405,8 @@ public class TemplateUrlService {
String query, String alternateTerm, boolean shouldPrefetch, String protocolVersion);
private native String nativeGetSearchEngineUrlFromTemplateUrl(
long nativeTemplateUrlServiceAndroid, String keyword);
+ private native String nativeAddSearchEngineForTesting(
+ long nativeTemplateUrlServiceAndroid, String keyword, int offset);
+ private native String nativeUpdateLastVisitedForTesting(
+ long nativeTemplateUrlServiceAndroid, String keyword);
}

Powered by Google App Engine
This is Rietveld 408576698