Issue 25555006: Collect more data to send in crash reports for a crasher that's stumping me.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25555006: Collect more data to send in crash reports for a crasher that's stumping me. (Closed)

Created:
7 years, 2 months ago by jam

Modified:
7 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Collect more data to send in crash reports for a crasher that's stumping me. BUG=302530 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226398

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	content/browser/plugin_process_host.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	content/browser/plugin_process_host.cc	View		2 chunks	+20 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

7 years, 2 months ago (2013-10-02 04:01:32 UTC) #2

lgtm

https://codereview.chromium.org/25555006/diff/1/content/browser/plugin_proces...
File content/browser/plugin_process_host.cc (right):

https://codereview.chromium.org/25555006/diff/1/content/browser/plugin_proces...
content/browser/plugin_process_host.cc:440: i != removed_pids_.end(); ++i) {
Undent 1 space :)

Expand Messages | Collapse Messages