Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25555005: Move text/BidiContext to Source/platform/ (Closed)

Created:
7 years, 2 months ago by pilgrim_google
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, darin (slow to review)
Visibility:
Public.

Description

Move text/BidiContext to Source/platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158819

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase, nits, fix include problem #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -200 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/platform/text/BidiContext.h View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/platform/text/BidiContext.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M Source/core/platform/text/BidiResolver.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/BidiRunList.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/text/BidiContext.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
A + Source/platform/text/BidiContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
7 years, 2 months ago (2013-10-02 03:24:32 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/25555005/diff/1/Source/platform/text/BidiContext.h File Source/platform/text/BidiContext.h (right): https://codereview.chromium.org/25555005/diff/1/Source/platform/text/BidiContext.h#newcode70 Source/platform/text/BidiContext.h:70: PLATFORM_EXPORT inline unsigned char nextGreaterOddLevel(unsigned char level) There's ...
7 years, 2 months ago (2013-10-02 06:29:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25555005/7001
7 years, 2 months ago (2013-10-02 18:43:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8305
7 years, 2 months ago (2013-10-02 23:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25555005/20001
7 years, 2 months ago (2013-10-03 02:28:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25555005/20001
7 years, 2 months ago (2013-10-03 05:41:45 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-03 09:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25555005/38001
7 years, 2 months ago (2013-10-03 13:23:53 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 15:18:57 UTC) #9
Message was sent while issue was closed. 
Change committed as 158819

Powered by Google App Engine
This is Rietveld 408576698