Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: gm/rebaseline_server/results.py

Issue 25555003: More improvements to HTTP baseline viewer (for GM results) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: delete_commented_out_HTML Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/rebaseline_server/static/loader.js » ('j') | gm/rebaseline_server/static/view.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/results.py
===================================================================
--- gm/rebaseline_server/results.py (revision 11566)
+++ gm/rebaseline_server/results.py (working copy)
@@ -205,11 +205,7 @@
"expectedHashDigest": str(expected_image[1]),
}
Results._AddToCategoryDict(category_dict, results_for_this_test)
-
- # TODO(epoger): For now, don't include succeeded results in the raw
- # data. There are so many of them that they make the client too slow.
- if updated_result_type != gm_json.JSONKEY_ACTUALRESULTS_SUCCEEDED:
- test_data.append(results_for_this_test)
+ test_data.append(results_for_this_test)
epoger 2013/10/01 21:16:10 Now that we limit the number of results shown, it'
return {"categories": category_dict, "testData": test_data}
@staticmethod
« no previous file with comments | « no previous file | gm/rebaseline_server/static/loader.js » ('j') | gm/rebaseline_server/static/view.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698