More improvements to HTTP baseline viewer (for GM results)

gm/rebaseline_server/results.py

 #!/usr/bin/python
 
 '''
 Copyright 2013 Google Inc.
 
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 '''
 
 '''
@@ skipping 187 matching lines @@
               "builder": builder,
               "test": test,
               "config": config,
               "resultType": updated_result_type,
               "actualHashType": actual_image[0],
               "actualHashDigest": str(actual_image[1]),
               "expectedHashType": expected_image[0],
               "expectedHashDigest": str(expected_image[1]),
           }
           Results._AddToCategoryDict(category_dict, results_for_this_test)
-
-          # TODO(epoger): For now, don't include succeeded results in the raw
-          # data. There are so many of them that they make the client too slow.
-          if updated_result_type != gm_json.JSONKEY_ACTUALRESULTS_SUCCEEDED:
-            test_data.append(results_for_this_test)
+          test_data.append(results_for_this_test)

[epoger, 2013/10/01 21:16:10]

Now that we limit the number of results shown, it's actually reasonable for the
client to download them all.  Even the successes.

     return {"categories": category_dict, "testData": test_data}
 
   @staticmethod
   def _AddToCategoryDict(category_dict, test_results):
     """Add test_results to the category dictionary we are building
     (see documentation of self.GetAll() for the format of this dictionary).
 
     params:
       category_dict: category dict-of-dicts to add to; modify this in-place
       test_results: test data with which to update category_list, in a dict:
          {
            "category_name": "category_value",
            "category_name": "category_value",
            ...
          }
     """
     for category in CATEGORIES_TO_SUMMARIZE:
       category_value = test_results.get(category)
       if not category_value:
         continue  # test_results did not include this category, keep going
       if not category_dict.get(category):
         category_dict[category] = {}
       if not category_dict[category].get(category_value):
         category_dict[category][category_value] = 0
       category_dict[category][category_value] += 1