Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2555493005: Add a documentation link to the chrome://profiler page. (Closed)

Created:
4 years ago by Sigurður Ásgeirsson
Modified:
4 years ago
Reviewers:
eroman
CC:
chromium-reviews, arv+watch_chromium.org, scheib
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a documentation link to the chrome://profiler page. BUG=644385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/56b333c5957668b0b572f321b9487a1fba2edb5d Cr-Commit-Position: refs/heads/master@{#436985}

Patch Set 1 #

Patch Set 2 : Remove CL dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/resources/profiler/profiler.html View 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Sigurður Ásgeirsson
Hey Eric, just added a quick documentation link to the profiler page. I've yet to ...
4 years ago (2016-12-06 20:12:57 UTC) #5
eroman
lgtm
4 years ago (2016-12-06 21:09:08 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2552333002 Patch 1). Please resolve the dependency and ...
4 years ago (2016-12-06 21:23:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555493005/20001
4 years ago (2016-12-07 15:54:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 17:05:06 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-07 17:09:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56b333c5957668b0b572f321b9487a1fba2edb5d
Cr-Commit-Position: refs/heads/master@{#436985}

Powered by Google App Engine
This is Rietveld 408576698