|
|
Chromium Code Reviews|
Created:
4 years ago by Sigurður Ásgeirsson Modified:
4 years ago Reviewers:
eroman CC:
chromium-reviews, arv+watch_chromium.org, scheib Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a documentation link to the chrome://profiler page.
BUG=644385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/56b333c5957668b0b572f321b9487a1fba2edb5d
Cr-Commit-Position: refs/heads/master@{#436985}
Patch Set 1 #Patch Set 2 : Remove CL dependency. #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Add a documentation link to the chrome://profiler page. BUG=644385 ========== to ========== Add a documentation link to the chrome://profiler page. BUG=644385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
siggi@chromium.org changed reviewers: + eroman@chromium.org
Hey Eric, just added a quick documentation link to the profiler page. I've yet to update the page with the memory profiling info, will do that once I enable this for official builds. Siggi
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by siggi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2552333002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by siggi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/2555493005/#ps20001 (title: "Remove CL dependency.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481126042937980,
"parent_rev": "53251d0d7a2a029d2c9dc334ce5fc4f15278410d", "commit_rev":
"6337cf110e0e396e08434576291f6f9b0e25d6d3"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add a documentation link to the chrome://profiler page. BUG=644385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add a documentation link to the chrome://profiler page. BUG=644385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/56b333c5957668b0b572f321b9487a1fba2edb5d Cr-Commit-Position: refs/heads/master@{#436985} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/56b333c5957668b0b572f321b9487a1fba2edb5d Cr-Commit-Position: refs/heads/master@{#436985} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
