Let `Isolate.errors` close on isolate exit.

Let `Isolate.errors` close on isolate exit.

It's not perfect because it won't catch an isolate exit that happens while nobody is listening.

Add test.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/aeb544351e2d80f2a45c6910a29dd9a87d79bf2c

[Lasse Reichstein Nielsen, 2016-12-07 13:26:54]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-12-07 16:12:00]

LGTM.

https://codereview.chromium.org/2555493003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/2555493003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:502: * If the isolate terminates while nobody is
listening, the returned
Doesn't this sentence imply the first one?

https://codereview.chromium.org/2555493003/diff/1/tests/isolate/isolate_error...
File tests/isolate/isolate_errors_test.dart (right):

https://codereview.chromium.org/2555493003/diff/1/tests/isolate/isolate_error...
tests/isolate/isolate_errors_test.dart:71: // {
Reenable or remove?

[Lasse Reichstein Nielsen, 2016-12-09 12:00:46]

Description was changed from

==========
Let `Isolate.errors` close on isolate exit.

It's not perfect because it won't catch an isolate exit that happens while
nobody is listening.

Add test.
==========

to

==========
Let `Isolate.errors` close on isolate exit.

It's not perfect because it won't catch an isolate exit that happens while
nobody is listening.

Add test.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aeb544351e2d80f2a45c6910a29dd9a87d79bf2c
==========

[Lasse Reichstein Nielsen, 2016-12-09 12:00:47]

Committed patchset #1 (id:1) manually as
aeb544351e2d80f2a45c6910a29dd9a87d79bf2c (presubmit successful).

[Lasse Reichstein Nielsen, 2016-12-09 12:02:30]

Description was changed from

==========
Let `Isolate.errors` close on isolate exit.

It's not perfect because it won't catch an isolate exit that happens while
nobody is listening.

Add test.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aeb544351e2d80f2a45c6910a29dd9a87d79bf2c
==========

to

==========
Let `Isolate.errors` close on isolate exit.

It's not perfect because it won't catch an isolate exit that happens while
nobody is listening.

Add test.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aeb544351e2d80f2a45c6910a29dd9a87d79bf2c
==========