Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Issue 2555493002: Moves cast-specific prefs into chromecast namespace. (Closed)

Created:
4 years ago by alokp
Modified:
4 years ago
Reviewers:
byungchul
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves cast-specific prefs into chromecast namespace. BUG=665489 Committed: https://crrev.com/b0e3523e5aa57d6e9ffba7af083835c0ebc5fdb7 Cr-Commit-Position: refs/heads/master@{#436357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/base/pref_names.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/base/pref_names.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
alokp
4 years ago (2016-12-05 17:53:11 UTC) #4
byungchul
lgtm
4 years ago (2016-12-05 17:59:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555493002/1
4 years ago (2016-12-05 18:18:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:25:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 18:28:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0e3523e5aa57d6e9ffba7af083835c0ebc5fdb7
Cr-Commit-Position: refs/heads/master@{#436357}

Powered by Google App Engine
This is Rietveld 408576698