Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2555483003: Don't fail clip-paths with empty bounds (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't fail clip-paths with empty bounds An empty nested clip-path should result in an empty clip-path (clipping away everything.) BUG=671543 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473 Cr-Commit-Position: refs/heads/master@{#436605}

Patch Set 1 #

Patch Set 2 : Add SPv2 expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/clip-path/nested-empty-clip-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
fs
4 years ago (2016-12-06 15:16:08 UTC) #9
f(malita)
lgtm
4 years ago (2016-12-06 15:18:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555483003/20001
4 years ago (2016-12-06 15:58:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 16:03:01 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-06 16:04:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bfec8883cac1e879727b3f95ae6de1b19146473
Cr-Commit-Position: refs/heads/master@{#436605}

Powered by Google App Engine
This is Rietveld 408576698