Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/edk/embedder/embedder_unittest.cc

Issue 2555483002: Add POSIX shared memory support for Mac (Closed)
Patch Set: Check that we never pass POSIX shm over Mojo. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/memory/shared_memory_handle.h ('K') | « ipc/ipc_message_utils.cc ('k') | mojo/edk/embedder/platform_shared_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/embedder_unittest.cc
diff --git a/mojo/edk/embedder/embedder_unittest.cc b/mojo/edk/embedder/embedder_unittest.cc
index 4521f8037ed2d44c3c1c67c5b96ea828b1fb5988..9cb8400a77f8bdfccd174bc47cbbb517c038093a 100644
--- a/mojo/edk/embedder/embedder_unittest.cc
+++ b/mojo/edk/embedder/embedder_unittest.cc
@@ -428,6 +428,7 @@ TEST_F(EmbedderTest, MultiprocessMachSharedMemory) {
// buffer from it.
base::SharedMemoryCreateOptions options;
options.size = 123;
+ options.type = base::SharedMemoryHandle::MACH;
base::SharedMemory shared_memory;
ASSERT_TRUE(shared_memory.Create(options));
base::SharedMemoryHandle shm_handle = base::SharedMemory::DuplicateHandle(
@@ -502,6 +503,7 @@ TEST_F(EmbedderTest, MultiprocessMixMachAndFds) {
} else {
base::SharedMemoryCreateOptions options;
options.size = kShmSize;
+ options.type = base::SharedMemoryHandle::MACH;
base::SharedMemory shared_memory;
ASSERT_TRUE(shared_memory.Create(options));
base::SharedMemoryHandle shm_handle =
« base/memory/shared_memory_handle.h ('K') | « ipc/ipc_message_utils.cc ('k') | mojo/edk/embedder/platform_shared_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698