Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: base/memory/shared_memory_handle_mac.cc

Issue 2555483002: Add POSIX shared memory support for Mac (Closed)
Patch Set: Check that we never pass POSIX shm over Mojo. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/shared_memory_handle.h" 5 #include "base/memory/shared_memory_handle.h"
6 6
7 #include <mach/mach_vm.h> 7 #include <mach/mach_vm.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <sys/mman.h> 9 #include <sys/mman.h>
10 #include <unistd.h> 10 #include <unistd.h>
11 11
12 #include "base/mac/mac_util.h" 12 #include "base/mac/mac_util.h"
13 #include "base/posix/eintr_wrapper.h" 13 #include "base/posix/eintr_wrapper.h"
14 14
15 namespace base { 15 namespace base {
16 16
17 SharedMemoryHandle::SharedMemoryHandle() {} 17 static_assert(sizeof(SharedMemoryHandle::Type) <=
18 sizeof(SharedMemoryHandle::TypeWireFormat),
19 "Size of enum SharedMemoryHandle::Type exceeds size of type "
20 "transmitted over wire.");
21
22 SharedMemoryHandle::SharedMemoryHandle() : type_(POSIX), file_descriptor_() {}
23
24 SharedMemoryHandle::SharedMemoryHandle(
25 const base::FileDescriptor& file_descriptor)
26 : type_(POSIX), file_descriptor_(file_descriptor) {}
27
28 SharedMemoryHandle::SharedMemoryHandle(int fd, bool auto_close)
29 : type_(POSIX), file_descriptor_(fd, auto_close) {}
18 30
19 SharedMemoryHandle::SharedMemoryHandle(mach_vm_size_t size) { 31 SharedMemoryHandle::SharedMemoryHandle(mach_vm_size_t size) {
32 type_ = MACH;
20 mach_port_t named_right; 33 mach_port_t named_right;
21 kern_return_t kr = mach_make_memory_entry_64( 34 kern_return_t kr = mach_make_memory_entry_64(
22 mach_task_self(), 35 mach_task_self(),
23 &size, 36 &size,
24 0, // Address. 37 0, // Address.
25 MAP_MEM_NAMED_CREATE | VM_PROT_READ | VM_PROT_WRITE, 38 MAP_MEM_NAMED_CREATE | VM_PROT_READ | VM_PROT_WRITE,
26 &named_right, 39 &named_right,
27 MACH_PORT_NULL); // Parent handle. 40 MACH_PORT_NULL); // Parent handle.
28 if (kr != KERN_SUCCESS) { 41 if (kr != KERN_SUCCESS) {
29 memory_object_ = MACH_PORT_NULL; 42 memory_object_ = MACH_PORT_NULL;
30 return; 43 return;
31 } 44 }
32 45
33 memory_object_ = named_right; 46 memory_object_ = named_right;
34 size_ = size; 47 size_ = size;
35 pid_ = GetCurrentProcId(); 48 pid_ = GetCurrentProcId();
36 ownership_passes_to_ipc_ = false; 49 ownership_passes_to_ipc_ = false;
37 } 50 }
38 51
39 SharedMemoryHandle::SharedMemoryHandle(mach_port_t memory_object, 52 SharedMemoryHandle::SharedMemoryHandle(mach_port_t memory_object,
40 mach_vm_size_t size, 53 mach_vm_size_t size,
41 base::ProcessId pid) 54 base::ProcessId pid)
42 : memory_object_(memory_object), 55 : type_(MACH),
56 memory_object_(memory_object),
43 size_(size), 57 size_(size),
44 pid_(pid), 58 pid_(pid),
45 ownership_passes_to_ipc_(false) {} 59 ownership_passes_to_ipc_(false) {}
46 60
47 SharedMemoryHandle::SharedMemoryHandle(const SharedMemoryHandle& handle) { 61 SharedMemoryHandle::SharedMemoryHandle(const SharedMemoryHandle& handle)
62 : type_(handle.type_) {
48 CopyRelevantData(handle); 63 CopyRelevantData(handle);
49 } 64 }
50 65
51 SharedMemoryHandle& SharedMemoryHandle::operator=( 66 SharedMemoryHandle& SharedMemoryHandle::operator=(
52 const SharedMemoryHandle& handle) { 67 const SharedMemoryHandle& handle) {
53 if (this == &handle) 68 if (this == &handle)
54 return *this; 69 return *this;
55 70
71 type_ = handle.type_;
56 CopyRelevantData(handle); 72 CopyRelevantData(handle);
57 return *this; 73 return *this;
58 } 74 }
59 75
60 SharedMemoryHandle SharedMemoryHandle::Duplicate() const { 76 SharedMemoryHandle SharedMemoryHandle::Duplicate() const {
61 if (!IsValid()) 77 switch (type_) {
62 return SharedMemoryHandle(MACH_PORT_NULL, 0, 0); 78 case POSIX: {
79 if (!IsValid())
80 return SharedMemoryHandle();
63 81
64 // Increment the ref count. 82 int duped_fd = HANDLE_EINTR(dup(file_descriptor_.fd));
65 kern_return_t kr = mach_port_mod_refs(mach_task_self(), memory_object_, 83 if (duped_fd < 0)
66 MACH_PORT_RIGHT_SEND, 1); 84 return SharedMemoryHandle();
67 DCHECK_EQ(kr, KERN_SUCCESS); 85 return SharedMemoryHandle(duped_fd, true);
68 SharedMemoryHandle handle(*this); 86 }
69 handle.SetOwnershipPassesToIPC(true); 87 case MACH: {
70 return handle; 88 if (!IsValid())
89 return SharedMemoryHandle(MACH_PORT_NULL, 0, 0);
90
91 // Increment the ref count.
92 kern_return_t kr = mach_port_mod_refs(mach_task_self(), memory_object_,
93 MACH_PORT_RIGHT_SEND, 1);
94 DCHECK_EQ(kr, KERN_SUCCESS);
95 SharedMemoryHandle handle(*this);
96 handle.SetOwnershipPassesToIPC(true);
97 return handle;
98 }
99 }
71 } 100 }
72 101
73 bool SharedMemoryHandle::operator==(const SharedMemoryHandle& handle) const { 102 bool SharedMemoryHandle::operator==(const SharedMemoryHandle& handle) const {
74 if (!IsValid() && !handle.IsValid()) 103 if (!IsValid() && !handle.IsValid())
75 return true; 104 return true;
76 105
77 return memory_object_ == handle.memory_object_ && size_ == handle.size_ && 106 if (type_ != handle.type_)
78 pid_ == handle.pid_; 107 return false;
108
109 switch (type_) {
110 case POSIX:
111 return file_descriptor_ == handle.file_descriptor_;
112 case MACH:
113 return memory_object_ == handle.memory_object_ && size_ == handle.size_ &&
114 pid_ == handle.pid_;
115 }
79 } 116 }
80 117
81 bool SharedMemoryHandle::operator!=(const SharedMemoryHandle& handle) const { 118 bool SharedMemoryHandle::operator!=(const SharedMemoryHandle& handle) const {
82 return !(*this == handle); 119 return !(*this == handle);
83 } 120 }
84 121
122 SharedMemoryHandle::Type SharedMemoryHandle::GetType() const {
123 return type_;
124 }
125
85 bool SharedMemoryHandle::IsValid() const { 126 bool SharedMemoryHandle::IsValid() const {
86 return memory_object_ != MACH_PORT_NULL; 127 switch (type_) {
128 case POSIX:
129 return file_descriptor_.fd >= 0;
130 case MACH:
131 return memory_object_ != MACH_PORT_NULL;
132 }
133 }
134
135 void SharedMemoryHandle::SetFileHandle(int fd, bool auto_close) {
136 DCHECK(!IsValid());
137 file_descriptor_.fd = fd;
138 file_descriptor_.auto_close = auto_close;
139 type_ = POSIX;
140 }
141
142 const FileDescriptor SharedMemoryHandle::GetFileDescriptor() const {
143 DCHECK_EQ(type_, POSIX);
144 return file_descriptor_;
87 } 145 }
88 146
89 mach_port_t SharedMemoryHandle::GetMemoryObject() const { 147 mach_port_t SharedMemoryHandle::GetMemoryObject() const {
148 DCHECK_EQ(type_, MACH);
90 return memory_object_; 149 return memory_object_;
91 } 150 }
92 151
93 bool SharedMemoryHandle::GetSize(size_t* size) const { 152 bool SharedMemoryHandle::GetSize(size_t* size) const {
94 if (!IsValid()) { 153 if (!IsValid())
95 *size = 0; 154 return false;
96 return true; 155
156 switch (type_) {
157 case SharedMemoryHandle::POSIX:
158 struct stat st;
159 if (fstat(file_descriptor_.fd, &st) != 0)
160 return false;
161 if (st.st_size < 0)
162 return false;
163 *size = st.st_size;
164 return true;
165 case SharedMemoryHandle::MACH:
166 *size = size_;
167 return true;
97 } 168 }
98
99 *size = size_;
100 return true;
101 } 169 }
102 170
103 bool SharedMemoryHandle::MapAt(off_t offset, 171 bool SharedMemoryHandle::MapAt(off_t offset,
104 size_t bytes, 172 size_t bytes,
105 void** memory, 173 void** memory,
106 bool read_only) { 174 bool read_only) {
107 DCHECK(IsValid()); 175 DCHECK(IsValid());
108 DCHECK_EQ(pid_, GetCurrentProcId()); 176 switch (type_) {
109 kern_return_t kr = mach_vm_map( 177 case SharedMemoryHandle::POSIX:
110 mach_task_self(), 178 *memory = mmap(nullptr, bytes, PROT_READ | (read_only ? 0 : PROT_WRITE),
111 reinterpret_cast<mach_vm_address_t*>(memory), // Output parameter 179 MAP_SHARED, file_descriptor_.fd, offset);
112 bytes, 180
113 0, // Alignment mask 181 return *memory && *memory != reinterpret_cast<void*>(-1);
114 VM_FLAGS_ANYWHERE, memory_object_, offset, 182 case SharedMemoryHandle::MACH:
115 FALSE, // Copy 183 DCHECK_EQ(pid_, GetCurrentProcId());
116 VM_PROT_READ | (read_only ? 0 : VM_PROT_WRITE), // Current protection 184 kern_return_t kr = mach_vm_map(
117 VM_PROT_WRITE | VM_PROT_READ | VM_PROT_IS_MASK, // Maximum protection 185 mach_task_self(),
118 VM_INHERIT_NONE); 186 reinterpret_cast<mach_vm_address_t*>(memory), // Output parameter
119 return kr == KERN_SUCCESS; 187 bytes,
188 0, // Alignment mask
189 VM_FLAGS_ANYWHERE,
190 memory_object_,
191 offset,
192 FALSE, // Copy
193 VM_PROT_READ | (read_only ? 0 : VM_PROT_WRITE), // Current protection
194 VM_PROT_WRITE | VM_PROT_READ | VM_PROT_IS_MASK, // Maximum protection
195 VM_INHERIT_NONE);
196 return kr == KERN_SUCCESS;
197 }
120 } 198 }
121 199
122 void SharedMemoryHandle::Close() const { 200 void SharedMemoryHandle::Close() const {
123 if (!IsValid()) 201 if (!IsValid())
124 return; 202 return;
125 203
126 kern_return_t kr = mach_port_deallocate(mach_task_self(), memory_object_); 204 switch (type_) {
127 if (kr != KERN_SUCCESS) 205 case POSIX:
128 DPLOG(ERROR) << "Error deallocating mach port: " << kr; 206 if (IGNORE_EINTR(close(file_descriptor_.fd)) < 0)
207 DPLOG(ERROR) << "Error closing fd.";
208 break;
209 case MACH:
210 kern_return_t kr = mach_port_deallocate(mach_task_self(), memory_object_);
211 if (kr != KERN_SUCCESS)
212 DPLOG(ERROR) << "Error deallocating mach port: " << kr;
213 break;
214 }
129 } 215 }
130 216
131 void SharedMemoryHandle::SetOwnershipPassesToIPC(bool ownership_passes) { 217 void SharedMemoryHandle::SetOwnershipPassesToIPC(bool ownership_passes) {
218 DCHECK_EQ(type_, MACH);
132 ownership_passes_to_ipc_ = ownership_passes; 219 ownership_passes_to_ipc_ = ownership_passes;
133 } 220 }
134 221
135 bool SharedMemoryHandle::OwnershipPassesToIPC() const { 222 bool SharedMemoryHandle::OwnershipPassesToIPC() const {
223 DCHECK_EQ(type_, MACH);
136 return ownership_passes_to_ipc_; 224 return ownership_passes_to_ipc_;
137 } 225 }
138 226
139 void SharedMemoryHandle::CopyRelevantData(const SharedMemoryHandle& handle) { 227 void SharedMemoryHandle::CopyRelevantData(const SharedMemoryHandle& handle) {
140 memory_object_ = handle.memory_object_; 228 switch (type_) {
141 size_ = handle.size_; 229 case POSIX:
142 pid_ = handle.pid_; 230 file_descriptor_ = handle.file_descriptor_;
143 ownership_passes_to_ipc_ = handle.ownership_passes_to_ipc_; 231 break;
232 case MACH:
233 memory_object_ = handle.memory_object_;
234 size_ = handle.size_;
235 pid_ = handle.pid_;
236 ownership_passes_to_ipc_ = handle.ownership_passes_to_ipc_;
237 break;
238 }
144 } 239 }
145 240
146 } // namespace base 241 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698