Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2555433003: [Sync] Plumb initial type set from engine to DTM. (Closed)

Created:
4 years ago by maxbogue
Modified:
4 years ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Plumb initial type set from engine to DTM. This change is in preparation for moving the synchronous configure logic out of SyncBackendRegistrar and into DataTypeManagerImpl. BUG=663125 Committed: https://crrev.com/27ff5590e848a211fc06eb383b3ac954fc5e9901 Cr-Commit-Position: refs/heads/master@{#437119}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -87 lines) Patch
M components/browser_sync/profile_sync_components_factory_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M components/browser_sync/profile_sync_service.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 3 chunks +46 lines, -48 lines 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service_mock.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service_startup_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/data_type_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/sync_api_component_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/sync_api_component_factory_mock.h View 1 chunk +4 lines, -3 lines 0 comments Download
M components/sync/engine/fake_sync_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/sync_engine_host.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
maxbogue
Pavel, PTAL. I think the changes in PSS are the only interesting ones; they're kinda ...
4 years ago (2016-12-06 20:30:06 UTC) #4
pavely
lgtm
4 years ago (2016-12-08 00:06:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555433003/20001
4 years ago (2016-12-08 00:25:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 01:39:10 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 01:44:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27ff5590e848a211fc06eb383b3ac954fc5e9901
Cr-Commit-Position: refs/heads/master@{#437119}

Powered by Google App Engine
This is Rietveld 408576698